Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mokuno@sm.sony.co.jp
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: : Emit event stream compat iw_point objects correctly.
Date: Thu, 27 Dec 2007 00:57:25 -0800 (PST)	[thread overview]
Message-ID: <20071227.005725.144782426.davem@davemloft.net> (raw)
In-Reply-To: <20071227173802.6F56.40F06B3A@sm.sony.co.jp>

From: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Date: Thu, 27 Dec 2007 17:51:49 +0900

> 	Hi
> 
> On Fri, 21 Dec 2007 20:58:08 -0800 (PST)
> David Miller <davem@davemloft.net> wrote:
> 
> > @@ -520,7 +530,7 @@ iwe_stream_add_point(char *	stream,		/* Stream of events */
> >  		memcpy(stream + IW_EV_LCP_LEN,
> >  		       ((char *) iwe) + IW_EV_LCP_LEN + IW_EV_POINT_OFF,
> >  		       IW_EV_POINT_PK_LEN - IW_EV_LCP_PK_LEN);
> 
> As the alignment of 64bit platforms may be defferent from 32bit one,
> should it be like the following?

IW_EV_LCP_LEN is the same on both 32-bit and 64-bit platforms, it is
just the size of the "len" and "cmd" portions of struct iw_event.

Those are both __u16, so IW_EV_LCP_LEN always evaluates to "4",
try it if you do not believe me. :-)

The iwreq_data size is invariant across the calculations.
If it's bigger on 64-bit, more will be subtracted in the
calculation performed by IW_EV_LCP_LEN.

So my patches are correct as-is and we do not need to
be mindful of compat'ness wrt. IW_EV_LCP_LEN.

  reply	other threads:[~2007-12-27  8:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22  4:58 [WEXT 12/12]: Emit event stream compat iw_point objects correctly David Miller
     [not found] ` <20071221.205808.213484078.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-12-27  8:51   ` : " Masakazu Mokuno
2007-12-27  8:57     ` David Miller [this message]
     [not found]       ` <20071227.005725.144782426.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-12-27  9:24         ` Masakazu Mokuno
     [not found]           ` <20071227181439.6F59.40F06B3A-DfbDroY8Xu1L9jVzuh4AOg@public.gmane.org>
2007-12-27  9:26             ` David Miller
2008-01-10  9:16           ` David Miller
     [not found]             ` <20080110.011602.74511551.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-01-11  4:16               ` Masakazu Mokuno
2008-06-03 16:57                 ` David Miller
     [not found]                   ` <20080603.095750.120470495.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-06-03 17:37                     ` David Miller
2008-01-21 11:23               ` Masakazu Mokuno
     [not found]                 ` <20080121194942.613C.40F06B3A-DfbDroY8Xu1L9jVzuh4AOg@public.gmane.org>
2008-01-21 11:37                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071227.005725.144782426.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mokuno@sm.sony.co.jp \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox