From: David Miller <davem@davemloft.net>
To: oliver@hartkopp.net
Cc: sam@ravnborg.org, urs@isnogud.escape.de, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227
Date: Thu, 27 Dec 2007 16:49:00 -0800 (PST) [thread overview]
Message-ID: <20071227.164900.233018217.davem@davemloft.net> (raw)
In-Reply-To: <477407C1.1050405@hartkopp.net>
From: Oliver Hartkopp <oliver@hartkopp.net>
Date: Thu, 27 Dec 2007 21:14:57 +0100
> This patch fixes the use of plain integers instead of __u32 in a struct
> that is visible from kernel space and user space. As this change is user
> visible this patch also updates the CAN version to 20071227.
>
> Thanks to Sam Ravnborg for pointing out the wrong plain int usage.
>
> It applies on the current net-2.6.25 tree.
The types are exactly the same size regardless of anything.
There is no reason to make such a big fuss about this, changing the
CAN version etc.
Also, since CAN has never shown up in a released kernel, there is
nothing to be incompatible with.
Finally, once CAN is in fact in a released kernel, you can't make
incompatible changes to the userland visible structures. They are
going to be fixed in stone.
Therefore I'm going to check this in without all the version
changes.
Thanks.
next prev parent reply other threads:[~2007-12-28 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 20:14 [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227 Oliver Hartkopp
2007-12-28 0:49 ` David Miller [this message]
2007-12-28 9:26 ` Oliver Hartkopp
2007-12-28 10:10 ` Oliver Hartkopp
2007-12-28 0:50 ` David Miller
2007-12-28 8:58 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071227.164900.233018217.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@hartkopp.net \
--cc=sam@ravnborg.org \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).