netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: vgusev@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: santize headers for iproute2
Date: Sat, 29 Dec 2007 19:22:12 -0800 (PST)	[thread overview]
Message-ID: <20071229.192212.149111967.davem@davemloft.net> (raw)
In-Reply-To: <20071225171310.1c43a0e2@deepthought>

From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Tue, 25 Dec 2007 17:13:10 -0800

> Well changing netinet/tcp.h is just not a realistic proposition, it takes
> too long to filter from glibc through distro's to be worth it.

But you have to, the ifdef mess you are suggesting is so much
worse.

Look at the reason you even have to do add the ifdefs, it's because
lo' and behold the congestion control defines have already propagated
properly into netinet/tcp.h

And this alone proves that your argument against putting this stuff in
the right place has no basis in reality.

Please just submit a patch to the appropriate place to get the
interfaces you need into netinet/tcp.h included instead of crapping
all over the kernel headers.

In the interum you can put a special header into the iproute2
distribution to handle this until it's sorted.

  reply	other threads:[~2007-12-30  3:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21 17:43 [PATCH] net: santize headers for iproute2 Stephen Hemminger
2007-12-25  6:05 ` David Miller
2007-12-25 20:43   ` Stephen Hemminger
2007-12-25 23:02     ` David Miller
2007-12-26  1:13       ` Stephen Hemminger
2007-12-30  3:22         ` David Miller [this message]
2007-12-31 18:55           ` Stephen Hemminger
2007-12-25 20:46   ` [PATCH] veth: move veth.h to include/linux Stephen Hemminger
2007-12-25 22:23     ` Sam Ravnborg
2007-12-26  1:14       ` Stephen Hemminger
2007-12-26  1:19         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071229.192212.149111967.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=vgusev@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).