From: Adrian Bunk <bunk@kernel.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate
Date: Sat, 29 Dec 2007 02:09:30 +0200 [thread overview]
Message-ID: <20071229000930.GD9105@does.not.exist> (raw)
In-Reply-To: <Pine.LNX.4.64.0712282348280.29013@fbirervta.pbzchgretzou.qr>
On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote:
> Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate
> so they can be built as modules. This will allow CONFIG_LLC to be
> built as a module too, overall reducing the core kernel image size.
>...
Just an example of code you have to fix if you do this:
$ grep -r "#ifdef CONFIG_TR" net/
net/802/sysctl_net_802.c:#ifdef CONFIG_TR
net/802/sysctl_net_802.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/atm/lec.c:#ifdef CONFIG_TR
net/ipv4/arp.c:#ifdef CONFIG_TR
net/llc/llc_output.c:#ifdef CONFIG_TR
net/sysctl_net.c:#ifdef CONFIG_TR
net/sysctl_net.c:#ifdef CONFIG_TR
$
For all variables you change to tristates you have to check every single
#ifdef in C code in the kernel using this variable whether it needs to
be fixed when it's modular.
You also have to check all usages of these variables in Kconfig files,
but my first impression is they are all OK.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-12-29 0:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 23:45 [PATCH] Make FC, FDDI, HIPPI and TR tristate Jan Engelhardt
2007-12-29 0:09 ` Adrian Bunk [this message]
2007-12-29 0:41 ` Jan Engelhardt
2007-12-29 0:52 ` Adrian Bunk
2007-12-29 8:19 ` David Miller
2007-12-29 8:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071229000930.GD9105@does.not.exist \
--to=bunk@kernel.org \
--cc=jengelh@computergmbh.de \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).