netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: skbuff data pointer alignment requirement
Date: Sat, 29 Dec 2007 14:04:14 +0100	[thread overview]
Message-ID: <20071229130414.GB3125@ami.dom.local> (raw)
In-Reply-To: <a967d7d00712281653m5b1a937ch898a5b48f8ee1887@mail.gmail.com>

On Fri, Dec 28, 2007 at 04:53:24PM -0800, Keyur Chudgar wrote:
> Hi Jarek,
> 
> > Do you mean hardware requirements of an architecture or a specific driver?
> I meant any hardware requirements of an architecture.
> 
> > So, if you have more than one network card, is it needed by all of them,
> > while other (not network) drivers are happy with default allocations?
> Yes. So, anything related to skbuff data block, will need specific alignment
> requirements, while others (non-network drivers) will work as default.

Hi Keyur,

It seems this is rather unusual case, probably something new, because 
considering the number of various architectures available on Linux it
looks like the first which requires this feature. Then, of course,
your proposal would make sense, but you should simply name this
hardware in your patch description. On the other hand, if it's
something very uncommon, it could be hard for you to convince somebody
to merge this change.

Regards,
Jarek P.

      parent reply	other threads:[~2007-12-29 13:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21  1:12 skbuff data pointer alignment requirement Keyur Chudgar
2007-12-22 11:00 ` Jarek Poplawski
     [not found]   ` <a967d7d00712281653m5b1a937ch898a5b48f8ee1887@mail.gmail.com>
2007-12-29  0:54     ` Fwd: " Keyur Chudgar
2007-12-29 13:04     ` Jarek Poplawski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071229130414.GB3125@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).