From: David Miller <davem@davemloft.net>
To: ramirose@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h
Date: Sun, 30 Dec 2007 23:26:31 -0800 (PST) [thread overview]
Message-ID: <20071230.232631.199492951.davem@davemloft.net> (raw)
In-Reply-To: <eb3ff54b0712280756m45c92c0bhc1298f6b428ac3ed@mail.gmail.com>
From: "Rami Rosen" <ramirose@gmail.com>
Date: Fri, 28 Dec 2007 17:56:46 +0200
> It seems to me that neigh_is_valid() inline method from
> include/net/neighbour.h can be removed since it is not used.
>
> Though it can be considered as an API for future use, and
> indeed we have neigh_is_connected() method in this same header (which is BTW
> used only in one place, drivers/net/cxgb3/l2t.c), we can easily notice
> that we don't have
> any accessor method to check whether the neighbour is in NUD_IN_TIMER
> (not to mention that we don't have methods to check the single neighbour states,
> like NUD_REACHABLE or NUD_DELAY or the other ones). So for consistency
> I suggest to
> consider removing the neigh_is_valid() method.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
This is a helper function which was used by drivers implementing
support for the old fast routing code which we removed years ago.
So yes we should remove this.
Patch applied.
prev parent reply other threads:[~2007-12-31 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 15:56 [PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h Rami Rosen
2007-12-31 7:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230.232631.199492951.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox