From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/3] [UDP]: add udp_mem, udp_rmem_min and udp_wmem_min Date: Mon, 31 Dec 2007 00:19:25 -0800 (PST) Message-ID: <20071231.001925.151533664.davem@davemloft.net> References: <47775D8C.5010104@redhat.com> <47775E7A.60708@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org, tyasui@redhat.com, mhiramat@redhat.com, satoshi.oshima.fk@hitachi.com, billfink@mindspring.com, andi@firstfloor.org, johnpol@2ka.mipt.ru, shemminger@linux-foundation.org, yoshfuji@linux-ipv6.org, yumiko.sugita.yf@hitachi.com To: haoki@redhat.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:40212 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752448AbXLaIT0 (ORCPT ); Mon, 31 Dec 2007 03:19:26 -0500 In-Reply-To: <47775E7A.60708@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Hideo AOKI Date: Sun, 30 Dec 2007 04:01:46 -0500 > diff -pruN net-2.6.25-t12t19m-p4/net/ipv4/proc.c net-2.6.25-t12t19m-p5/net/ipv4/proc.c > --- net-2.6.25-t12t19m-p4/net/ipv4/proc.c 2007-12-27 10:19:02.000000000 -0500 > +++ net-2.6.25-t12t19m-p5/net/ipv4/proc.c 2007-12-29 21:09:21.000000000 -0500 > @@ -56,7 +56,8 @@ static int sockstat_seq_show(struct seq_ > sock_prot_inuse(&tcp_prot), atomic_read(&tcp_orphan_count), > tcp_death_row.tw_count, atomic_read(&tcp_sockets_allocated), > atomic_read(&tcp_memory_allocated)); > - seq_printf(seq, "UDP: inuse %d\n", sock_prot_inuse(&udp_prot)); > + seq_printf(seq, "UDP: inuse %d mem %d\n", sock_prot_inuse(&udp_prot), > + atomic_read(&udp_memory_allocated)); > seq_printf(seq, "UDPLITE: inuse %d\n", sock_prot_inuse(&udplite_prot)); > seq_printf(seq, "RAW: inuse %d\n", sock_prot_inuse(&raw_prot)); > seq_printf(seq, "FRAG: inuse %d memory %d\n", More careless patch creation. :-/ This breaks the build because udp_memory_allocated is not added until patch 2. Once again I'll combine all three patches into one but I am extremely angry about how careless and broken these two patch submissions were.