netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [IPSEC]: Kill duplicate xfrm_policy_flush prototype
@ 2008-01-02  3:02 Herbert Xu
  2008-01-02  3:08 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2008-01-02  3:02 UTC (permalink / raw)
  To: David S. Miller, netdev

Hi Dave:

[IPSEC]: Kill duplicate xfrm_policy_flush prototype

For five years we had two xfrm_policy_flush prototypes and every time that
function's signature changed people have been diligently updating both of
them without noticing :)

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 2b6246a..1dbd2f9 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -1316,7 +1316,6 @@ extern int xfrm_alloc_spi(struct xfrm_state *x, u32 minspi, u32 maxspi);
 struct xfrm_state * xfrm_find_acq(u8 mode, u32 reqid, u8 proto,
 				  xfrm_address_t *daddr, xfrm_address_t *saddr,
 				  int create, unsigned short family);
-extern int xfrm_policy_flush(u8 type, struct xfrm_audit *audit_info);
 extern int xfrm_sk_policy_insert(struct sock *sk, int dir, struct xfrm_policy *pol);
 extern int xfrm_bundle_ok(struct xfrm_policy *pol, struct xfrm_dst *xdst,
 			  struct flowi *fl, int family, int strict);

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [IPSEC]: Kill duplicate xfrm_policy_flush prototype
  2008-01-02  3:02 [IPSEC]: Kill duplicate xfrm_policy_flush prototype Herbert Xu
@ 2008-01-02  3:08 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-02  3:08 UTC (permalink / raw)
  To: herbert; +Cc: netdev

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 2 Jan 2008 14:02:11 +1100

> [IPSEC]: Kill duplicate xfrm_policy_flush prototype
> 
> For five years we had two xfrm_policy_flush prototypes and every time that
> function's signature changed people have been diligently updating both of
> them without noticing :)
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Quite amazing if you ask me :-)

Patch applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-02  3:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-02  3:02 [IPSEC]: Kill duplicate xfrm_policy_flush prototype Herbert Xu
2008-01-02  3:08 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).