netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-2.6.25] [IPV4] Remove three declarations of unimplemented methods and correct a typo in include/net/ip.h
@ 2008-01-01  8:30 Rami Rosen
  2008-01-02  5:13 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2008-01-01  8:30 UTC (permalink / raw)
  To: davem; +Cc: netdev

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi,
These three declarations in include/net/ip.h are not implemented
anywhere:
ip_mc_dropsocket(), ip_mc_dropdevice() and ip_net_unreachable().

Also, correct a comment to be "Functions provided by ip_fragment.c"
(instead of by ip_fragment.o) in consistency with the other comments in this
header.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 788 bytes --]

diff --git a/include/net/ip.h b/include/net/ip.h
index 5fab3a1..8be48c8 100644
--- a/include/net/ip.h
+++ b/include/net/ip.h
@@ -82,8 +82,6 @@ struct packet_type;
 struct rtable;
 struct sockaddr;
 
-extern void		ip_mc_dropsocket(struct sock *);
-extern void		ip_mc_dropdevice(struct net_device *dev);
 extern int		igmp_mc_proc_init(void);
 
 /*
@@ -319,7 +317,7 @@ static __inline__ void inet_reset_saddr(struct sock *sk)
 extern int	ip_call_ra_chain(struct sk_buff *skb);
 
 /*
- *	Functions provided by ip_fragment.o
+ *	Functions provided by ip_fragment.c
  */
 
 enum ip_defrag_users
@@ -342,7 +340,6 @@ int ip_frag_nqueues(void);
  */
  
 extern int ip_forward(struct sk_buff *skb);
-extern int ip_net_unreachable(struct sk_buff *skb);
  
 /*
  *	Functions provided by ip_options.c

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-2.6.25] [IPV4] Remove three declarations of unimplemented methods and correct a typo in include/net/ip.h
  2008-01-01  8:30 [PATCH net-2.6.25] [IPV4] Remove three declarations of unimplemented methods and correct a typo in include/net/ip.h Rami Rosen
@ 2008-01-02  5:13 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-02  5:13 UTC (permalink / raw)
  To: ramirose; +Cc: netdev

From: "Rami Rosen" <ramirose@gmail.com>
Date: Tue, 1 Jan 2008 10:30:53 +0200

> These three declarations in include/net/ip.h are not implemented
> anywhere:
> ip_mc_dropsocket(), ip_mc_dropdevice() and ip_net_unreachable().
> 
> Also, correct a comment to be "Functions provided by ip_fragment.c"
> (instead of by ip_fragment.o) in consistency with the other comments in this
> header.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-02  5:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-01  8:30 [PATCH net-2.6.25] [IPV4] Remove three declarations of unimplemented methods and correct a typo in include/net/ip.h Rami Rosen
2008-01-02  5:13 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).