From: Christoph Hellwig <hch@infradead.org>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 00/26] atl1: divide and modernize
Date: Tue, 1 Jan 2008 17:58:40 +0000 [thread overview]
Message-ID: <20080101175839.GA25201@infradead.org> (raw)
In-Reply-To: <1199154173-4058-1-git-send-email-jacliburn@bellsouth.net>
On Mon, Dec 31, 2007 at 08:22:27PM -0600, Jay Cliburn wrote:
>
> [Neglected to cc netdev in the first wave.]
>
> Hello Jeff,
>
> Happy New Year to you and all.
>
> In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
> we propose to move the existing atl1 driver to a new directory
> (drivers/net/atlx), then split out functions and definitions that both
> atl1 and atl2 can share. The final structure will look like this:
>
> directory or file status
> ======================= ==========================
> drivers/net/atl1/ deleted
> drivers/net/atlx/ new
> drivers/net/atlx/atl1.c atl1-specific functions
> drivers/net/atlx/atl1.h atl1-specific definitions
> drivers/net/atlx/atlx.c atl1-atl2 shared functions
> drivers/net/atlx/atlx.h atl1-atl2 shared definitions
>
> The first two patches submitted in this patchset accomplish the relocation
> by movng the atl1 driver -- lock, stock, and barrel -- over to
> drivers/net/atlx, then splitting out shareable functions and definitions.
> Some transitory hackery will be present until the atl2 merge. Please
> overlook it for now.
>
> The remaining 24 patches bring the atl1 driver up to par with the current
> vendor driver version 1.2.40.2. NAPI support is included and it seems
> to work, but it needs to be scrutinized by an experienced eye. I had a
> hard time finding much current NAPI documentation, so I just hacked at
> it by looking at the e1000 driver.
How much shared code is going to be there in the end? Unless it's a lot
I fear that the maintaince burden far outweights the benefit of having
shared code.
next prev parent reply other threads:[~2008-01-01 17:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 2:22 [PATCH 00/26] atl1: divide and modernize Jay Cliburn
2008-01-01 2:22 ` [PATCH 01/26] atl1: relocate atl1 driver to /drivers/net/atlx Jay Cliburn
2008-01-01 2:22 ` [PATCH 02/26] atl1: move common functions to atlx files Jay Cliburn
2008-01-01 2:22 ` [PATCH 03/26] atl1: fix broken TSO Jay Cliburn
2008-01-01 2:22 ` [PATCH 04/26] atl1: add ethtool register dump Jay Cliburn
2008-01-01 2:22 ` [PATCH 05/26] atl1: print debug info if rrd error Jay Cliburn
2008-01-01 2:22 ` [PATCH 06/26] atl1: update initialization parameters Jay Cliburn
2008-01-01 2:22 ` [PATCH 07/26] atl1: clarify max rx frame size Jay Cliburn
2008-01-01 2:22 ` [PATCH 08/26] atl1: additional DMA engine configuration Jay Cliburn
2008-01-01 2:22 ` [PATCH 09/26] atl1: refactor tx processing Jay Cliburn
2008-01-01 2:22 ` [PATCH 10/26] atl1: use csum_start Jay Cliburn
2008-01-01 2:22 ` [PATCH 11/26] atl1: refactor initialization and startup Jay Cliburn
2008-01-01 2:22 ` [PATCH 12/26] atl1: refactor atl1_probe Jay Cliburn
2008-01-01 2:22 ` [PATCH 13/26] atl1: refactor interrupt handling Jay Cliburn
2008-01-01 2:22 ` [PATCH 14/26] atl1: move stray defines to header file Jay Cliburn
2008-01-01 2:22 ` [PATCH 15/26] atl1: tidy up ring management Jay Cliburn
2008-01-01 2:22 ` [PATCH 16/26] atl1: modernize check link function Jay Cliburn
2008-01-01 2:22 ` [PATCH 17/26] atl1: update phy config function Jay Cliburn
2008-01-01 2:22 ` [PATCH 18/26] atl1: make function static Jay Cliburn
2008-01-01 2:22 ` [PATCH 19/26] atl1: modernize down/up functions Jay Cliburn
2008-01-01 2:22 ` [PATCH 20/26] atl1: update change mtu Jay Cliburn
2008-01-01 2:22 ` [PATCH 21/26] atl1: update atl1_close Jay Cliburn
2008-01-01 2:22 ` [PATCH 22/26] atl1: update netpoll Jay Cliburn
2008-01-01 2:22 ` [PATCH 23/26] atl1: update shutdown and remove functions Jay Cliburn
2008-01-01 2:22 ` [PATCH 24/26] atl1: update wake-on-lan Jay Cliburn
2008-01-01 2:22 ` [PATCH 25/26] atl1: add NAPI support Jay Cliburn
2008-01-01 5:58 ` Stephen Hemminger
2008-01-01 2:22 ` [PATCH 26/26] atl1: remove experimental tag and clean up comments Jay Cliburn
2008-01-01 17:58 ` Christoph Hellwig [this message]
2008-01-01 18:12 ` [PATCH 00/26] atl1: divide and modernize Jay Cliburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101175839.GA25201@infradead.org \
--to=hch@infradead.org \
--cc=jacliburn@bellsouth.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).