netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Denys Fedoryshchenko" <denys@visp.net.lb>
To: Andreas Henriksson <andreas@fatal.se>, Patrick McHardy <kaber@trash.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: iproute2 syntax change in tc police?
Date: Wed, 2 Jan 2008 02:43:44 +0200	[thread overview]
Message-ID: <20080102003909.M73325@visp.net.lb> (raw)
In-Reply-To: <1199230752.16358.22.camel@localhost.localdomain>

Maybe something like 
-tc filter add dev ppp0 parent ffff: protocol ip prio 50 u32 match ip src 
0.0.0.0/0 police rate 4mbit burst 10k drop flowid :1
+tc filter add dev ppp0 parent ffff: protocol ip prio 50 u32 match ip src 
0.0.0.0/0 flowid :1 police rate 4mbit burst 10k drop 

I can't test it now, but in my case moving flowid BEFORE police (or somewhere 
else "before", i dont remeber well) - helped.

On Wed, 02 Jan 2008 00:39:11 +0100, Andreas Henriksson wrote
> Hello Patrick McHardy!
> 
> We have recently updated iproute in debian and have reports about the
> new version breaking shorewall generated scripts.
> 
> The original bug-report can be found at:
> http://bugs.debian.org/458539
> 
> Commands like "tc filter add dev ppp0 parent ffff: protocol ip prio 
> 50 u32 match ip src 0.0.0.0/0 police rate 4mbit burst 10k drop 
> flowid :1" apparently no longer works. The flowid is not accepted anymore.
> Reverting commit 720a2e8d99... which you authored seems to "fix" this.
> 
> http://git.kernel.org/?p=linux/kernel/git/shemminger/
iproute2.git;a=commitdiff;h=720a2e8d990707749b2cafa77ab3cd2b8241ec47
> 
> I guess the flowid is invalid syntax, but that it just got ignored
> instead of caught before... 
> Could you please have a look and tell me what you think about this?
> 
> -- 
> Regards,
> Andreas Henriksson
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
Denys Fedoryshchenko
Technical Manager
Virtual ISP S.A.L.


  reply	other threads:[~2008-01-02 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-01 23:39 iproute2 syntax change in tc police? Andreas Henriksson
2008-01-02  0:43 ` Denys Fedoryshchenko [this message]
2008-01-02 10:14 ` Andreas Henriksson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080102003909.M73325@visp.net.lb \
    --to=denys@visp.net.lb \
    --cc=andreas@fatal.se \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).