iproute2 syntax change in tc police?

iproute2 syntax change in tc police?

[Andreas Henriksson]

Hello Patrick McHardy!

We have recently updated iproute in debian and have reports about the
new version breaking shorewall generated scripts. 

The original bug-report can be found at:
http://bugs.debian.org/458539


Commands like "tc filter add dev ppp0 parent ffff: protocol ip prio 50
u32 match ip src 0.0.0.0/0 police rate 4mbit burst 10k drop flowid :1"
apparently no longer works. The flowid is not accepted anymore.
Reverting commit 720a2e8d99... which you authored seems to "fix" this.

http://git.kernel.org/?p=linux/kernel/git/shemminger/iproute2.git;a=commitdiff;h=720a2e8d990707749b2cafa77ab3cd2b8241ec47

I guess the flowid is invalid syntax, but that it just got ignored
instead of caught before... 
Could you please have a look and tell me what you think about this?


-- 
Regards,
Andreas Henriksson

Re: iproute2 syntax change in tc police?

[Denys Fedoryshchenko]

Maybe something like 
-tc filter add dev ppp0 parent ffff: protocol ip prio 50 u32 match ip src 
0.0.0.0/0 police rate 4mbit burst 10k drop flowid :1
+tc filter add dev ppp0 parent ffff: protocol ip prio 50 u32 match ip src 
0.0.0.0/0 flowid :1 police rate 4mbit burst 10k drop 

I can't test it now, but in my case moving flowid BEFORE police (or somewhere 
else "before", i dont remeber well) - helped.

On Wed, 02 Jan 2008 00:39:11 +0100, Andreas Henriksson wrote
> Hello Patrick McHardy!
> 
> We have recently updated iproute in debian and have reports about the
> new version breaking shorewall generated scripts.
> 
> The original bug-report can be found at:
> http://bugs.debian.org/458539
> 
> Commands like "tc filter add dev ppp0 parent ffff: protocol ip prio 
> 50 u32 match ip src 0.0.0.0/0 police rate 4mbit burst 10k drop 
> flowid :1" apparently no longer works. The flowid is not accepted anymore.
> Reverting commit 720a2e8d99... which you authored seems to "fix" this.
> 
> http://git.kernel.org/?p=linux/kernel/git/shemminger/
iproute2.git;a=commitdiff;h=720a2e8d990707749b2cafa77ab3cd2b8241ec47
> 
> I guess the flowid is invalid syntax, but that it just got ignored
> instead of caught before... 
> Could you please have a look and tell me what you think about this?
> 
> -- 
> Regards,
> Andreas Henriksson
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
Denys Fedoryshchenko
Technical Manager
Virtual ISP S.A.L.

Re: iproute2 syntax change in tc police?

[Andreas Henriksson]

On ons, 2008-01-02 at 00:39 +0100, Andreas Henriksson wrote:
[...]
> Commands like "tc filter add dev ppp0 parent ffff: protocol ip prio 50
> u32 match ip src 0.0.0.0/0 police rate 4mbit burst 10k drop flowid :1"
> apparently no longer works. The flowid is not accepted anymore.
> Reverting commit 720a2e8d99... which you authored seems to "fix" this.
[...]


After further investigation it seems clear to me that reverting the
commit 720a2e8d990707749b2... is the correct thing to do, since the real
fix for the problem this commit was supposed to fix was instead fixed in
commit c29391c7c68f031e246c...

Whatever you specify after a u32 police you will now get a syntax error,
and according to "tc filter add u32 help" there are several things that
you are supposed to be able to specify after a police.

So, Steven, please revert 720a2e8d990707749b2...


-- 
Regards,
Andreas Henriksson