netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Paul Moore <paul.moore@hp.com>
Cc: hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] NET: Clone the sk_buff->iif field properly
Date: Thu, 3 Jan 2008 22:13:12 +0100	[thread overview]
Message-ID: <20080103211312.GA7258@ami.dom.local> (raw)
In-Reply-To: <200801031115.34886.paul.moore@hp.com>

On Thu, Jan 03, 2008 at 11:15:34AM -0500, Paul Moore wrote:
...
> While I'm at it, is there some reason for this #define in __skb_clone()?
> 
>  #define C(x) n->x = skb->x
> 
> ... it seems kinda silly to me and I tend to think the code would be 
> better without it.

IMHO, if there are a lot of this, it's definitely more readable: easier
to check which values are simply copied and which need something more.
But, as usual, it's probably a question of taste, and of course without
it it would definitely look classier...

Cheers,
Jarek P.

PS: I hope you didn't suggest earlier my (better?) knowlege of git;
otherwise don't bother: with your git push you are far ahead of my
gitweb 'degree'.

  reply	other threads:[~2008-01-03 21:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 16:01 [RFC PATCH] NET: Clone the sk_buff->iif field properly Paul Moore
2008-01-03  9:58 ` Jarek Poplawski
2008-01-03 11:23   ` jamal
2008-01-03 14:01     ` Paul Moore
2008-01-03 16:15     ` Paul Moore
2008-01-03 21:13       ` Jarek Poplawski [this message]
2008-01-03 21:20         ` Paul Moore
2008-01-03 22:06           ` Jarek Poplawski
2008-01-03 22:49             ` Jarek Poplawski
2008-01-03 23:05           ` David Miller
2008-01-03 23:13             ` Paul Moore
2008-01-03 23:25               ` David Miller
2008-01-03 23:40               ` Joe Perches
2008-01-04  3:19                 ` Paul Moore
2008-01-04  3:36                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103211312.GA7258@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    --cc=paul.moore@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).