From: David Miller <davem@davemloft.net>
To: markmc@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [INET] Fix netdev renaming and inet address labels
Date: Fri, 04 Jan 2008 00:57:04 -0800 (PST) [thread overview]
Message-ID: <20080104.005704.267427157.davem@davemloft.net> (raw)
In-Reply-To: <1199375823-28729-1-git-send-email-markmc@redhat.com>
From: Mark McLoughlin <markmc@redhat.com>
Date: Thu, 3 Jan 2008 15:57:03 +0000
> When re-naming an interface, the previous secondary address
> labels get lost e.g.
>
> $> brctl addbr foo
> $> ip addr add 192.168.0.1 dev foo
> $> ip addr add 192.168.0.2 dev foo label foo:00
> $> ip addr show dev foo | grep inet
> inet 192.168.0.1/32 scope global foo
> inet 192.168.0.2/32 scope global foo:00
> $> ip link set foo name bar
> $> ip addr show dev bar | grep inet
> inet 192.168.0.1/32 scope global bar
> inet 192.168.0.2/32 scope global bar:2
>
> Turns out to be a simple thinko in inetdev_changename() - clearly we
> want to look at the address label, rather than the device name, for
> a suffix to retain.
>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
This bug has been there since the function in question was
written :-)
Patch applied, thanks Mark.
prev parent reply other threads:[~2008-01-04 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 15:57 [PATCH] [INET] Fix netdev renaming and inet address labels Mark McLoughlin
2008-01-04 8:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104.005704.267427157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).