From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org, auke-jan.h.kok@intel.com
Subject: Re: NAPI poll behavior in various Intel drivers
Date: Fri, 04 Jan 2008 13:24:43 -0800 (PST) [thread overview]
Message-ID: <20080104.132443.25068269.davem@davemloft.net> (raw)
In-Reply-To: <477E92B6.8010809@katalix.com>
From: James Chapman <jchapman@katalix.com>
Date: Fri, 04 Jan 2008 20:10:30 +0000
> With the latest NAPI, this code has to change. But rather than remove
> the tx_cleaned logic completely, shouldn't transmit processing be
> included in the work_done accounting when a driver does transmit cleanup
> processing in the poll?
Most other NAPI drivers don't do this, they just process all the
pending TX work unconditionally and do not account it into the NAPI
poll work.
The logic is that, like link state handling, TX work is very cheap and
not the cpu cycle eater that RX packet processing is.
next prev parent reply other threads:[~2008-01-04 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 11:40 NAPI poll behavior in various Intel drivers David Miller
2008-01-04 20:10 ` James Chapman
2008-01-04 21:24 ` David Miller [this message]
2008-01-05 0:18 ` James Chapman
2008-01-05 7:25 ` David Miller
2008-01-05 13:29 ` Andi Kleen
2008-01-06 4:15 ` David Miller
2008-01-07 8:24 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104.132443.25068269.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=auke-jan.h.kok@intel.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).