From: Paul Moore <paul.moore@hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"Ilpo J??rvinen" <ilpo.jarvinen@helsinki.fi>
Cc: davem@davemloft.net, netdev@vger.kernel.org, acme@redhat.com,
latten@us.ibm.com
Subject: Re: [PATCH 3/4] [XFRM]: Kill some bloat
Date: Sat, 5 Jan 2008 22:25:18 -0500 [thread overview]
Message-ID: <200801052225.19165.paul.moore@hp.com> (raw)
In-Reply-To: <E1JBJOR-0000jO-00@gondolin.me.apana.org.au>
On Saturday 05 January 2008 7:29:35 pm Herbert Xu wrote:
> Ilpo J??rvinen <ilpo.jarvinen@helsinki.fi> wrote:
> > Signed-off-by: Ilpo J??rvinen <ilpo.jarvinen@helsinki.fi>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> > #ifdef CONFIG_AUDITSYSCALL
> > -static inline void xfrm_audit_helper_sainfo(struct xfrm_state *x,
> > - struct audit_buffer
> > *audit_buf) +static void xfrm_audit_helper_sainfo(struct xfrm_state *x,
> > + struct audit_buffer *audit_buf)
>
> We should never use inline except when it's on the fast path and this
> is definitely not a fast path. If a function ends up being called
> just once the compiler will most likely inline it anyway, making the
> use of the keyword inline redundant.
For the record the inline was there before the audit patch I submitted ...
then again, I suppose I could have removed the inline while I was at it, I
just didn't notice it. Sorry about that.
Thanks for fixing this guys.
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2008-01-06 3:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 13:39 [PATCH net-2.6.25 0/4] [NET]: Bloat, bloat and more bloat Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 1/4] [NETFILTER]: Kill some supper dupper bloatry Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 2/4] [IPVS]: Kill some bloat Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 3/4] [XFRM]: " Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 4/4] [CCID3]: " Ilpo Järvinen
2008-01-05 14:44 ` Arnaldo Carvalho de Melo
2008-01-06 7:13 ` David Miller
2008-01-06 0:29 ` [PATCH 3/4] [XFRM]: " Herbert Xu
2008-01-06 3:25 ` Paul Moore [this message]
2008-01-06 7:16 ` David Miller
2008-01-07 7:13 ` Ilpo Järvinen
2008-01-07 7:32 ` Herbert Xu
2008-01-08 0:23 ` Andi Kleen
2008-01-08 1:54 ` David Miller
2008-01-08 2:05 ` Andi Kleen
2008-01-08 2:08 ` [PATCH 3/4] [XFRM]: Kill some bloat II Andi Kleen
2008-01-08 3:37 ` [PATCH 3/4] [XFRM]: Kill some bloat David Miller
2008-01-08 5:00 ` Andi Kleen
2008-01-08 5:10 ` David Miller
2008-01-08 10:48 ` Ilpo Järvinen
2008-01-10 13:53 ` Ilpo Järvinen
2008-01-08 10:57 ` Ilpo Järvinen
2008-01-07 8:21 ` Ilpo Järvinen
2008-01-07 10:02 ` Herbert Xu
2008-01-06 7:13 ` David Miller
2008-01-06 7:12 ` [PATCH 2/4] [IPVS]: " David Miller
2008-01-06 7:11 ` [PATCH 1/4] [NETFILTER]: Kill some supper dupper bloatry David Miller
2008-01-05 14:46 ` [PATCH net-2.6.25 0/4] [NET]: Bloat, bloat and more bloat Arnaldo Carvalho de Melo
2008-01-09 11:35 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801052225.19165.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=latten@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).