From: Al Viro <viro@ZenIV.linux.org.uk>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: m.kozlowski@tuxland.pl, davem@davemloft.net,
sparclinux@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sparc oops in ip_fast_csum
Date: Sun, 6 Jan 2008 02:02:14 +0000 [thread overview]
Message-ID: <20080106020214.GQ27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1JBJHA-0000hy-00@gondolin.me.apana.org.au>
On Sun, Jan 06, 2008 at 11:22:04AM +1100, Herbert Xu wrote:
> Actually if you read the code for ip_fast_csum it's obvious what has
> happened. %o1 == iph->ihl contains the value 2 which is bogus.
>
> [IPV4] raw: Strengthen check on validity of iph->ihl
>
> We currently check that iph->ihl is bounded by the real length and that
> the real length is greater than the minimum IP header length. However,
> we did not check the caes where iph->ihl is less than the minimum IP
> header length.
>
> This breaks because some ip_fast_csum implementations assume that which
> is quite reasonable.
Humm... Point, but that makes me wonder what other callers do...
E.g. what about ipt_REJECT.c::send_reset()? Or myri10ge_get_frag_header()?
next prev parent reply other threads:[~2008-01-06 2:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 17:37 sparc oops in ip_fast_csum Mariusz Kozlowski
2008-01-05 9:44 ` Al Viro
2008-01-06 0:22 ` Herbert Xu
2008-01-06 0:57 ` Jan Engelhardt
2008-01-06 1:03 ` Herbert Xu
2008-01-06 2:02 ` Al Viro [this message]
2008-01-06 4:14 ` Herbert Xu
2008-01-14 6:09 ` Patrick McHardy
2008-01-14 6:19 ` David Miller
2008-01-06 7:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106020214.GQ27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).