From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org,
ralf@linux-mips.org, jgarzik@pobox.com
Subject: Re: [PATCH] METH: fix MAC address handling
Date: Sun, 6 Jan 2008 12:38:16 +0100 [thread overview]
Message-ID: <20080106113815.GA6140@alpha.franken.de> (raw)
In-Reply-To: <20080106.002305.99653155.davem@davemloft.net>
On Sun, Jan 06, 2008 at 12:23:05AM -0800, David Miller wrote:
> > + u64 macaddr;
> >
> > - for (i = 0; i < 6; i++)
> > - dev->dev_addr[i] = o2meth_eaddr[i];
> > DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
> > - mace->eth.mac_addr = (*(unsigned long*)o2meth_eaddr) >> 16;
> > + macaddr = 0;
> > + for (i = 0; i < 6; i++)
> > + macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
> > +
> > + mace->eth.mac_addr = macaddr;
> > }
> >
> > /*
>
> Can you double-check that this conversion is equivalent.
yes, I did.
> I know that this whole driver is full of assumptions about
> the endianness of the system this chip is found on, so
> I'm only interested in if the transformation is equivalent
> and the driver will keep working properly.
I've tested the driver and it's still working :-)
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2008-01-06 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 22:48 [PATCH] METH: fix MAC address handling Thomas Bogendoerfer
2008-01-06 8:23 ` David Miller
2008-01-06 11:38 ` Thomas Bogendoerfer [this message]
2008-01-07 1:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106113815.GA6140@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).