From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: herbert@gondor.apana.org.au, ilpo.jarvinen@helsinki.fi,
netdev@vger.kernel.org, acme@redhat.com, paul.moore@hp.com,
latten@us.ibm.com
Subject: Re: [PATCH 3/4] [XFRM]: Kill some bloat
Date: Mon, 07 Jan 2008 21:10:18 -0800 (PST) [thread overview]
Message-ID: <20080107.211018.160153013.davem@davemloft.net> (raw)
In-Reply-To: <20080108050007.GA25338@one.firstfloor.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 8 Jan 2008 06:00:07 +0100
> On Mon, Jan 07, 2008 at 07:37:00PM -0800, David Miller wrote:
> > The vast majority of them are one, two, and three liners.
>
> % awk ' { line++ } ; /^{/ { total++; start = line } ; /^}/ { len=line-start-3; if (len > 4) l++; if (len >= 10) k++; } ; END { print total, l, l/total, k, k/total }' < include/net/tcp.h
> 68 28 0.411765 20 0.294118
>
> 41% are over 4 lines, 29% are >= 10 lines.
Take out the comments and whitespace lines, your script is
too simplistic.
next prev parent reply other threads:[~2008-01-08 5:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 13:39 [PATCH net-2.6.25 0/4] [NET]: Bloat, bloat and more bloat Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 1/4] [NETFILTER]: Kill some supper dupper bloatry Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 2/4] [IPVS]: Kill some bloat Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 3/4] [XFRM]: " Ilpo Järvinen
2008-01-05 13:39 ` [PATCH 4/4] [CCID3]: " Ilpo Järvinen
2008-01-05 14:44 ` Arnaldo Carvalho de Melo
2008-01-06 7:13 ` David Miller
2008-01-06 0:29 ` [PATCH 3/4] [XFRM]: " Herbert Xu
2008-01-06 3:25 ` Paul Moore
2008-01-06 7:16 ` David Miller
2008-01-07 7:13 ` Ilpo Järvinen
2008-01-07 7:32 ` Herbert Xu
2008-01-08 0:23 ` Andi Kleen
2008-01-08 1:54 ` David Miller
2008-01-08 2:05 ` Andi Kleen
2008-01-08 2:08 ` [PATCH 3/4] [XFRM]: Kill some bloat II Andi Kleen
2008-01-08 3:37 ` [PATCH 3/4] [XFRM]: Kill some bloat David Miller
2008-01-08 5:00 ` Andi Kleen
2008-01-08 5:10 ` David Miller [this message]
2008-01-08 10:48 ` Ilpo Järvinen
2008-01-10 13:53 ` Ilpo Järvinen
2008-01-08 10:57 ` Ilpo Järvinen
2008-01-07 8:21 ` Ilpo Järvinen
2008-01-07 10:02 ` Herbert Xu
2008-01-06 7:13 ` David Miller
2008-01-06 7:12 ` [PATCH 2/4] [IPVS]: " David Miller
2008-01-06 7:11 ` [PATCH 1/4] [NETFILTER]: Kill some supper dupper bloatry David Miller
2008-01-05 14:46 ` [PATCH net-2.6.25 0/4] [NET]: Bloat, bloat and more bloat Arnaldo Carvalho de Melo
2008-01-09 11:35 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107.211018.160153013.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=latten@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).