From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: paul.moore@hp.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb_clone()
Date: Mon, 07 Jan 2008 21:48:46 -0800 (PST) [thread overview]
Message-ID: <20080107.214846.40512910.davem@davemloft.net> (raw)
In-Reply-To: <Xine.LNX.4.64.0801080810010.15645@us.intercode.com.au>
From: James Morris <jmorris@namei.org>
Date: Tue, 8 Jan 2008 08:11:11 +1100 (EST)
> On Mon, 7 Jan 2008, Paul Moore wrote:
>
> > Both NetLabel and SELinux (other LSMs may grow to use it as well) rely on the
> > 'iif' field to determine the receiving network interface of inbound packets.
> > Unfortunately, at present this field is not preserved across a skb clone
> > operation which can lead to garbage values if the cloned skb is sent back
> > through the network stack. This patch corrects this problem by properly
> > copying the 'iif' field in __skb_clone() and removing the 'iif' field
> > assignment from skb_act_clone() since it is no longer needed.
> >
> > Also, while we are here, put the assignments in the same order as the offsets
> > to reduce cacheline bounces.
> >
> > Signed-off-by: Paul Moore <paul.moore@hp.com>
>
> Dave, perhaps this one should pushed to Linus now as a bugfix?
Probably we should, yes.
Ok, that's what I'll do.
next prev parent reply other threads:[~2008-01-08 5:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 17:47 [RFC PATCH v2 0/2] Labeled networking core stack changes for 2.6.25 Paul Moore
2008-01-07 17:47 ` [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb_clone() Paul Moore
2008-01-07 21:11 ` James Morris
2008-01-08 5:48 ` David Miller [this message]
2008-01-08 6:01 ` David Miller
2008-01-07 17:47 ` [RFC PATCH v2 2/2] SELinux: Add network ingress and egress control permission checks Paul Moore
2008-01-08 6:02 ` David Miller
2008-01-08 13:13 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107.214846.40512910.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).