netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org
Subject: Re: [IPV4] ROUTE: ip_rt_dump() is unecessary slow
Date: Mon, 07 Jan 2008 21:52:53 -0800 (PST)	[thread overview]
Message-ID: <20080107.215253.250616600.davem@davemloft.net> (raw)
In-Reply-To: <20080107193002.df137d57.dada1@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Mon, 7 Jan 2008 19:30:02 +0100

> I noticed "ip route list cache x.y.z.t" can be *very* slow.
> 
> While strace-ing -T it I also noticed that first part of route cache is
> fetched quite fast :
 ...
> The following patch corrects this performance/latency problem, removing quadratic behavior.
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

I think removing quadratic behavior is a bug fix, thus applied
to net-2.6, thanks Eric :-)

  reply	other threads:[~2008-01-08  5:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 18:30 [IPV4] ROUTE: ip_rt_dump() is unecessary slow Eric Dumazet
2008-01-08  5:52 ` David Miller [this message]
2008-01-08  6:11   ` Eric Dumazet
2008-01-08  6:15     ` David Miller
2008-01-08  6:37       ` Eric Dumazet
2008-01-09  6:02         ` Herbert Xu
2008-01-09  7:38           ` [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache Eric Dumazet
2008-01-09  9:46             ` Herbert Xu
2008-01-09 10:37               ` Eric Dumazet
2008-01-09 14:22                 ` Paul E. McKenney
2008-01-09 14:31                   ` David Miller
2008-01-09 14:43                     ` Paul E. McKenney
2008-01-09 17:36                     ` Eric Dumazet
2008-01-10 11:56                 ` David Miller
2008-01-10 14:06                 ` [DECNET] ROUTE: fix rcu_dereference() uses in /proc/net/decnet_cache Eric Dumazet
2008-01-11  6:35                   ` David Miller
2008-01-10 23:10                 ` [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache Jarek Poplawski
2008-01-10 23:51                   ` Paul E. McKenney
2008-01-11 14:13                     ` Jarek Poplawski
2008-01-11  0:00                   ` Herbert Xu
2008-01-11  8:30                     ` Jarek Poplawski
2008-01-11  9:11                       ` Jarek Poplawski
2008-01-11  9:23                         ` Jarek Poplawski
2008-01-11 10:38                         ` Herbert Xu
2008-01-11 11:30                           ` Jarek Poplawski
2008-01-11 10:37                       ` Herbert Xu
2008-01-11 12:31                         ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080107.215253.250616600.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).