netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: B.Steinbrink@gmx.de
Cc: arbrandes@gmail.com, bunk@kernel.org, andi@lisas.de,
	richie@coderworld.net, linux-kernel@vger.kernel.org,
	aabdulla@nvidia.com, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: forcedeth: MAC-address reversed on resume from suspend
Date: Mon, 07 Jan 2008 23:23:55 -0800 (PST)	[thread overview]
Message-ID: <20080107.232355.228915298.davem@davemloft.net> (raw)
In-Reply-To: <20080107014638.GA4170@atjola.homenet>

From: Björn Steinbrink <B.Steinbrink@gmx.de>
Date: Mon, 7 Jan 2008 02:46:38 +0100

> On 2008.01.06 19:49:49 -0200, Adolfo R. Brandes wrote:
> >  I have this forcedeth MAC address reversal problem when suspending
> > on 2 distinct boxes.  I can confirm Steinbrink's patch fixes the
> > problem on only one of them:
> > 
> > 00:0a.0 Bridge: nVidia Corporation CK804 Ethernet Controller (rev f3)
> > 
> >  On the other one the problem persists:
> > 
> > 00:14.0 Bridge: nVidia Corporation MCP51 Ethernet Controller (rev a1)
> 
> Thanks. Leaves me pretty clueless though. Especially since it worked for
> Richard, who also has a MCP51. In a private mail, you said that you had
> hardcoded the mac address in the source. Any chance that you applied the
> patch on your modified sources and didn't get it right?

I am going to push this patch upstream, it is correct and we
have a positive test case that failed before, so overall it's
a net improvement even if we still don't exactly know why
Adolfo's case still fails.

Let me know if there are any follow-on patches.

Thanks.

  parent reply	other threads:[~2008-01-08  7:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <477BFC71.7090002@coderworld.net>
     [not found] ` <20080102214843.GA19224@rhlx01.hs-esslingen.de>
2008-01-02 23:42   ` forcedeth: MAC-address reversed on resume from suspend Adrian Bunk
2008-01-04  3:43     ` Björn Steinbrink
2008-01-04  8:45       ` Andreas Mohr
2008-01-04 10:17         ` Björn Steinbrink
2008-01-04 22:43           ` Andreas Mohr
2008-01-05  6:10             ` Björn Steinbrink
2008-01-05  6:39               ` Björn Steinbrink
     [not found]       ` <477E3DEA.4070001@coderworld.net>
2008-01-04 22:26         ` [PATCH] Fix forcedeth reversing the MAC address on suspend Björn Steinbrink
2008-01-07  1:47           ` Björn Steinbrink
2008-01-06 21:49       ` forcedeth: MAC-address reversed on resume from suspend Adolfo R. Brandes
2008-01-07  1:46         ` Björn Steinbrink
2008-01-07 12:02           ` Adolfo R. Brandes
2008-01-08  7:23           ` David Miller [this message]
2008-02-16  9:41             ` Adolfo R. Brandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080107.232355.228915298.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=B.Steinbrink@gmx.de \
    --cc=aabdulla@nvidia.com \
    --cc=andi@lisas.de \
    --cc=arbrandes@gmail.com \
    --cc=bunk@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richie@coderworld.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).