From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: dada1@cosmosbay.com, netdev@vger.kernel.org, dim@openvz.org,
kuznet@ms2.inr.ac.ru
Subject: Re: [SOCK]: Adds a rcu_dereference() in sk_filter
Date: Tue, 08 Jan 2008 23:41:54 -0800 (PST) [thread overview]
Message-ID: <20080108.234154.107152881.davem@davemloft.net> (raw)
In-Reply-To: <E1JCUFO-00079j-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 09 Jan 2008 17:17:06 +1100
> Eric Dumazet <dada1@cosmosbay.com> wrote:
> >
> > It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU
> > protection for sk_filter(), without a rcu_dereference()
> >
> > Either we need a rcu_dereference(), either a comment should explain why we
> > dont need it. I vote for the former.
> >
> > Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks everyone.
prev parent reply other threads:[~2008-01-09 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 20:31 [SOCK]: Adds a rcu_dereference() in sk_filter Eric Dumazet
2008-01-09 6:17 ` Herbert Xu
2008-01-09 7:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108.234154.107152881.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=dim@openvz.org \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).