From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: andi@firstfloor.org, jheffner@psc.edu, ilpo.jarvinen@helsinki.fi,
lachlan.andrew@gmail.com, netdev@vger.kernel.org,
quetchen@caltech.edu
Subject: Re: SACK scoreboard
Date: Wed, 9 Jan 2008 08:03:18 +0100 [thread overview]
Message-ID: <20080109070318.GA8581@one.firstfloor.org> (raw)
In-Reply-To: <20080108.223925.105105455.davem@davemloft.net>
> It adds severe spikes in CPU utilization that are even moderate
> line rates begins to affect RTTs.
>
> Or do you think it's OK to process 500,000 SKBs while locked
> in a software interrupt.
You can always push it into a work queue. Even put it to
other cores if you want.
In fact this is already done partly for the ->completion_queue.
Wouldn't be a big change to queue it another level down.
Also even freeing a lot of objects doesn't have to be
that expensive. I suspect the most cost is in taking
the slab locks, but that could be batched. Without
that the kmem_free fast path isn't particularly
expensive, as long as the headers are still in cache.
Long ago I had sk_buff optimized for the routing case so that freeing
can be all done with a single cache line. That is
long gone, but could be probably restored.
But asking for protocol changes just to work around such a
internal implementation detail is ... <I miss words>
> Perhaps you have another broken awk script to prove this :-)
Your hand waved numbers on inline sizes there were definitely worse
than mine.
-Andi
next prev parent reply other threads:[~2008-01-09 7:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aa7d2c6d0711261023m3d2dd850o76a8f44aef022f39@mail.gmail.com>
[not found] ` <001001c83063$9adbc9d0$d5897e82@csp.uiuc.edu>
2007-11-28 23:47 ` [PATCH] tcp-illinois: incorrect beta usage Stephen Hemminger
2007-11-29 0:25 ` Lachlan Andrew
2007-11-29 0:43 ` Stephen Hemminger
2007-11-29 5:26 ` Shao Liu
2007-12-03 22:52 ` [RFC] TCP illinois max rtt aging Stephen Hemminger
2007-12-03 23:06 ` Lachlan Andrew
2007-12-03 23:59 ` Shao Liu
2007-12-04 0:32 ` Stephen Hemminger
2007-12-04 1:23 ` Lachlan Andrew
2007-12-04 8:37 ` Ilpo Järvinen
2007-12-07 3:27 ` Lachlan Andrew
2007-12-07 11:05 ` Ilpo Järvinen
2007-12-07 12:41 ` David Miller
2007-12-07 13:05 ` Ilpo Järvinen
2007-12-07 18:27 ` Ilpo Järvinen
2007-12-08 1:32 ` David Miller
2007-12-11 11:59 ` [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one (Was: Re: [RFC] TCP illinois max rtt aging) Ilpo Järvinen
2007-12-11 12:32 ` [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one David Miller
2007-12-12 0:14 ` Lachlan Andrew
2007-12-12 15:11 ` David Miller
2007-12-12 23:35 ` Lachlan Andrew
2007-12-12 23:38 ` David Miller
2007-12-13 0:00 ` Stephen Hemminger
2007-12-15 9:51 ` SACK scoreboard (Was: Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one) Ilpo Järvinen
2008-01-08 7:36 ` SACK scoreboard David Miller
2008-01-08 12:12 ` Ilpo Järvinen
2008-01-09 7:58 ` David Miller
2008-01-08 16:51 ` John Heffner
2008-01-08 22:44 ` David Miller
2008-01-09 1:34 ` Lachlan Andrew
2008-01-09 6:35 ` David Miller
2008-01-09 2:25 ` Andi Kleen
2008-01-09 4:27 ` John Heffner
2008-01-09 6:41 ` David Miller
2008-01-09 14:56 ` John Heffner
2008-01-09 18:14 ` SANGTAE HA
2008-01-09 18:23 ` John Heffner
2008-01-09 12:55 ` Ilpo Järvinen
2008-01-09 6:39 ` David Miller
2008-01-09 7:03 ` Andi Kleen [this message]
2008-01-09 7:16 ` David Miller
2008-01-09 9:47 ` Evgeniy Polyakov
2008-01-09 14:02 ` Andi Kleen
2007-11-29 14:12 ` [PATCH] tcp-illinois: incorrect beta usage Herbert Xu
2008-01-09 6:04 SACK scoreboard linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109070318.GA8581@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=jheffner@psc.edu \
--cc=lachlan.andrew@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=quetchen@caltech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).