netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Benny Amorsen <benny+usenet@amorsen.dk>,
	Chuck Ebbert <cebbert@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH take2] Re: Nested VLAN causes recursive locking error
Date: Thu, 10 Jan 2008 22:08:16 +0100	[thread overview]
Message-ID: <20080110210816.GA3064@ami.dom.local> (raw)
In-Reply-To: <47863A4A.6070303@trash.net>

On Thu, Jan 10, 2008 at 04:31:22PM +0100, Patrick McHardy wrote:
...
> No, this seems fine, thanks. Even better would be a way to get
> the last lockdep subclass through lockdep somehow, but I couldn't
> find a clean way for this. So I've applied your patch and also
> fixed macvlan.

As a matter of fact this simplified version was done mainly to remove
this bad looking effect of a never decreased global. Of course, your
proposal with using parent's subclass + 1 would be better, if deeper
nestings are required: so, I could try to enhance this (probably with
such additional lockdep macro) after some hint.

But still some 'quirks' are possible there: removing and adding
devices 'properly' would often require resetting of many subclasses,
so quite a lot of activities if more devices. And probably not very
common if not requested until now...

Thanks,
Jarek P.

  reply	other threads:[~2008-01-10 21:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 23:03 Nested VLAN causes recursive locking error Chuck Ebbert
2007-12-20 13:52 ` [PATCH] " Jarek Poplawski
2007-12-31 15:04   ` Patrick McHardy
2007-12-31 17:45     ` Jarek Poplawski
2007-12-31 17:54       ` Jarek Poplawski
2007-12-31 21:59       ` Jarek Poplawski
2008-01-02 16:40   ` Benny Amorsen
2008-01-02 23:41     ` [PATCH take2] " Jarek Poplawski
2008-01-10 15:31       ` Patrick McHardy
2008-01-10 21:08         ` Jarek Poplawski [this message]
2008-01-10 21:33           ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080110210816.GA3064@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=benny+usenet@amorsen.dk \
    --cc=cebbert@redhat.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).