From: Christoph Hellwig <hch@infradead.org>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: NetDev <netdev@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #3)
Date: Fri, 11 Jan 2008 09:17:28 +0000 [thread overview]
Message-ID: <20080111091728.GB14910@infradead.org> (raw)
In-Reply-To: <4786AB0C.6010202@intel.com>
On Thu, Jan 10, 2008 at 03:32:28PM -0800, Kok, Auke wrote:
> - cleaned up largely against sparse, checkpatch
largely means not completely, right? Please make sure there's no sparse
warnings left at least. checkpatch is not that criticial, but it would
be good to have an explanation for everything left.
some comments on the patch
- please remove that sill copyright heder on the Makefile, it's hard
to claim any rights on a trivial 3 line makefile.
- also please use igb-y instead of igb-objs in the Makefile
- the driver would be a lot more readable (and more importantly
hackable) if it was written in a natural flow instead of having dozends
of lines of forward declarations in every file.
- so you're adding your own phy abstraction. Is there a good reason
you can't simply use the generic phylib?
next prev parent reply other threads:[~2008-01-11 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 23:32 RFC: igb: Intel 82575 gigabit ethernet driver (take #3) Kok, Auke
2008-01-11 0:01 ` Jeff Garzik
2008-01-11 0:22 ` Kok, Auke
2008-01-11 9:17 ` Christoph Hellwig [this message]
2008-01-22 10:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111091728.GB14910@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).