From: Jarek Poplawski <jarkao2@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
davem@davemloft.net, dipankar@in.ibm.com, netdev@vger.kernel.org
Subject: Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache
Date: Fri, 11 Jan 2008 13:31:32 +0100 [thread overview]
Message-ID: <20080111123132.GC2708@ff.dom.local> (raw)
In-Reply-To: <20080111103742.GA26740@gondor.apana.org.au>
On Fri, Jan 11, 2008 at 09:37:42PM +1100, Herbert Xu wrote:
> On Fri, Jan 11, 2008 at 09:30:10AM +0100, Jarek Poplawski wrote:
> >
> > It looks like I'm really too lazy and/or these selfdocumenting features
> > of RCU are a bit overrated: one can never be sure which pointer is
> > really RCU protected without checking a few places?! So, after looking
> > at this rt_cache_get_next() and this patch only, it's looks like the
> > third candidate after seq->private and rtable...
>
> Perhaps we could introduce a sparse attribute for it?
I hope I won't be cursed by all those forced to additional writing,
so I'd only admit that after this patch there should be no problem
with identifying RCU protected data properly (maybe only this kind
of rcu_dereference() needs some popularization).
Jarek P.
prev parent reply other threads:[~2008-01-11 12:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 18:30 [IPV4] ROUTE: ip_rt_dump() is unecessary slow Eric Dumazet
2008-01-08 5:52 ` David Miller
2008-01-08 6:11 ` Eric Dumazet
2008-01-08 6:15 ` David Miller
2008-01-08 6:37 ` Eric Dumazet
2008-01-09 6:02 ` Herbert Xu
2008-01-09 7:38 ` [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache Eric Dumazet
2008-01-09 9:46 ` Herbert Xu
2008-01-09 10:37 ` Eric Dumazet
2008-01-09 14:22 ` Paul E. McKenney
2008-01-09 14:31 ` David Miller
2008-01-09 14:43 ` Paul E. McKenney
2008-01-09 17:36 ` Eric Dumazet
2008-01-10 11:56 ` David Miller
2008-01-10 14:06 ` [DECNET] ROUTE: fix rcu_dereference() uses in /proc/net/decnet_cache Eric Dumazet
2008-01-11 6:35 ` David Miller
2008-01-10 23:10 ` [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache Jarek Poplawski
2008-01-10 23:51 ` Paul E. McKenney
2008-01-11 14:13 ` Jarek Poplawski
2008-01-11 0:00 ` Herbert Xu
2008-01-11 8:30 ` Jarek Poplawski
2008-01-11 9:11 ` Jarek Poplawski
2008-01-11 9:23 ` Jarek Poplawski
2008-01-11 10:38 ` Herbert Xu
2008-01-11 11:30 ` Jarek Poplawski
2008-01-11 10:37 ` Herbert Xu
2008-01-11 12:31 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111123132.GC2708@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=dipankar@in.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).