* [PATCH 1/5] spidernet: add missing initialization
@ 2008-01-11 6:38 Ishizaki Kou
2008-01-11 12:44 ` Jens Osterkamp
2008-01-23 13:53 ` [Cbe-oss-dev] " Jens Osterkamp
0 siblings, 2 replies; 9+ messages in thread
From: Ishizaki Kou @ 2008-01-11 6:38 UTC (permalink / raw)
To: linas; +Cc: netdev, cbe-oss-dev
This patch fixes initialization of "aneg_count" and "medium" fields in
spider_net_card to make spidernet driver correctly sets "link status".
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
---
Index: linux-powerpc-git/drivers/net/spider_net.c
===================================================================
--- linux-powerpc-git.orig/drivers/net/spider_net.c
+++ linux-powerpc-git/drivers/net/spider_net.c
@@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device
spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
/* reset phy and setup aneg */
+ card->aneg_count = 0;
+ card->medium = BCM54XX_COPPER;
spider_net_setup_aneg(card);
mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
@@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
goto init_firmware_failed;
/* start probing with copper */
+ card->aneg_count = 0;
+ card->medium = BCM54XX_COPPER;
spider_net_setup_aneg(card);
if (card->phy.def->phy_id)
mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/5] spidernet: add missing initialization
2008-01-11 6:38 [PATCH 1/5] spidernet: add missing initialization Ishizaki Kou
@ 2008-01-11 12:44 ` Jens Osterkamp
2008-01-11 16:48 ` Linas Vepstas
2008-01-17 10:22 ` Ishizaki Kou
2008-01-23 13:53 ` [Cbe-oss-dev] " Jens Osterkamp
1 sibling, 2 replies; 9+ messages in thread
From: Jens Osterkamp @ 2008-01-11 12:44 UTC (permalink / raw)
To: Ishizaki Kou; +Cc: linasvepstas, netdev, cbe-oss-dev, Jeff Garzik
On Friday 11 January 2008, Ishizaki Kou wrote:
> This patch fixes initialization of "aneg_count" and "medium" fields in
> spider_net_card to make spidernet driver correctly sets "link status".
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Hi Ishizaki,
Linas has left the company and is no longer doing kernel related stuff,
so I suggest, given Jeff is ok with that, that the two of us take over
spidernet maintainership.
Jens
---
Change maintainership for spidernet.
Signed-off-by: Jens Osterkamp <jens@de.ibm.com>
Index: linux-2.6/MAINTAINERS
===================================================================
--- linux-2.6.orig/MAINTAINERS 2008-01-11 13:32:04.000000000 +0100
+++ linux-2.6/MAINTAINERS 2008-01-11 13:41:32.000000000 +0100
@@ -3613,8 +3613,10 @@
S: Supported
SPIDERNET NETWORK DRIVER for CELL
-P: Linas Vepstas
-M: linas@austin.ibm.com
+P: Ishizaki Kou
+M: kou.ishizaki@toshiba.co.jp
+P: Jens Osterkamp
+M: jens@de.ibm.com
L: netdev@vger.kernel.org
S: Supported
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/5] spidernet: add missing initialization
2008-01-11 12:44 ` Jens Osterkamp
@ 2008-01-11 16:48 ` Linas Vepstas
2008-01-12 22:52 ` Jeff Garzik
2008-01-17 10:22 ` Ishizaki Kou
1 sibling, 1 reply; 9+ messages in thread
From: Linas Vepstas @ 2008-01-11 16:48 UTC (permalink / raw)
To: Jens Osterkamp; +Cc: Ishizaki Kou, netdev, cbe-oss-dev, Jeff Garzik
Hi,
On 11/01/2008, Jens Osterkamp <jens@de.ibm.com> wrote:
> Hi Ishizaki,
>
> Linas has left the company and is no longer doing kernel related stuff,
> so I suggest, given Jeff is ok with that, that the two of us take over
> spidernet maintainership.
>
> Jens
>
> ---
>
> Change maintainership for spidernet.
>
> Signed-off-by: Jens Osterkamp <jens@de.ibm.com>
Fine with me ...
Acked-by: Linas Vepstas <linasvepstas@gmail.com>
> Index: linux-2.6/MAINTAINERS
> ===================================================================
> --- linux-2.6.orig/MAINTAINERS 2008-01-11 13:32:04.000000000 +0100
> +++ linux-2.6/MAINTAINERS 2008-01-11 13:41:32.000000000 +0100
> @@ -3613,8 +3613,10 @@
> S: Supported
>
> SPIDERNET NETWORK DRIVER for CELL
> -P: Linas Vepstas
> -M: linas@austin.ibm.com
> +P: Ishizaki Kou
> +M: kou.ishizaki@toshiba.co.jp
> +P: Jens Osterkamp
> +M: jens@de.ibm.com
> L: netdev@vger.kernel.org
> S: Supported
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/5] spidernet: add missing initialization
2008-01-11 16:48 ` Linas Vepstas
@ 2008-01-12 22:52 ` Jeff Garzik
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2008-01-12 22:52 UTC (permalink / raw)
To: linasvepstas; +Cc: Jens Osterkamp, Ishizaki Kou, netdev, cbe-oss-dev
applied
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/5] spidernet: add missing initialization
2008-01-11 12:44 ` Jens Osterkamp
2008-01-11 16:48 ` Linas Vepstas
@ 2008-01-17 10:22 ` Ishizaki Kou
1 sibling, 0 replies; 9+ messages in thread
From: Ishizaki Kou @ 2008-01-17 10:22 UTC (permalink / raw)
To: jens; +Cc: netdev, cbe-oss-dev
Jens-san,
> Hi Ishizaki,
>
> Linas has left the company and is no longer doing kernel related stuff,
> so I suggest, given Jeff is ok with that, that the two of us take over
> spidernet maintainership.
(snip)
> Change maintainership for spidernet.
>
> Signed-off-by: Jens Osterkamp <jens@de.ibm.com>
I apologize to my late reply.
I hope to accept your suggestion. But I have to get authorization
to take maintainership in my company. I have started negotiation
to my boss.
I can't check that spidernet driver works on Cell Blade, because I
don't have one. So I hope you check spidernet driver works on Cell
Blade when it changes.
And then, will you review our latest patches?
Best regards,
Kou Ishizaki
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization
2008-01-11 6:38 [PATCH 1/5] spidernet: add missing initialization Ishizaki Kou
2008-01-11 12:44 ` Jens Osterkamp
@ 2008-01-23 13:53 ` Jens Osterkamp
2008-01-28 13:40 ` Jens Osterkamp
1 sibling, 1 reply; 9+ messages in thread
From: Jens Osterkamp @ 2008-01-23 13:53 UTC (permalink / raw)
To: cbe-oss-dev; +Cc: Ishizaki Kou, netdev
On Friday 11 January 2008, Ishizaki Kou wrote:
> This patch fixes initialization of "aneg_count" and "medium" fields in
> spider_net_card to make spidernet driver correctly sets "link status".
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Jens Osterkamp <jens@de.ibm.com>
> ---
>
> Index: linux-powerpc-git/drivers/net/spider_net.c
> ===================================================================
> --- linux-powerpc-git.orig/drivers/net/spider_net.c
> +++ linux-powerpc-git/drivers/net/spider_net.c
> @@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device
> spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
>
> /* reset phy and setup aneg */
> + card->aneg_count = 0;
> + card->medium = BCM54XX_COPPER;
> spider_net_setup_aneg(card);
> mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
>
> @@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
> goto init_firmware_failed;
>
> /* start probing with copper */
> + card->aneg_count = 0;
> + card->medium = BCM54XX_COPPER;
> spider_net_setup_aneg(card);
> if (card->phy.def->phy_id)
> mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev
>
--
Gruß,
Jens
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization
2008-01-23 13:53 ` [Cbe-oss-dev] " Jens Osterkamp
@ 2008-01-28 13:40 ` Jens Osterkamp
0 siblings, 0 replies; 9+ messages in thread
From: Jens Osterkamp @ 2008-01-28 13:40 UTC (permalink / raw)
To: Jeff Garzik; +Cc: cbe-oss-dev, netdev, Ishizaki Kou
Jeff,
this series of 5 patches by Ishizaki-san runs fine on the blade, I tested it
for a few days. Besides it fixes a nasty bug in spidernet RX descriptor handling.
Can you please consider it for 2.6.25 ?
Thanks !
Jens
On Wednesday 23 January 2008, Jens Osterkamp wrote:
> On Friday 11 January 2008, Ishizaki Kou wrote:
> > This patch fixes initialization of "aneg_count" and "medium" fields in
> > spider_net_card to make spidernet driver correctly sets "link status".
> >
> > Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
>
> Acked-by: Jens Osterkamp <jens@de.ibm.com>
>
> > ---
> >
> > Index: linux-powerpc-git/drivers/net/spider_net.c
> > ===================================================================
> > --- linux-powerpc-git.orig/drivers/net/spider_net.c
> > +++ linux-powerpc-git/drivers/net/spider_net.c
> > @@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device
> > spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
> >
> > /* reset phy and setup aneg */
> > + card->aneg_count = 0;
> > + card->medium = BCM54XX_COPPER;
> > spider_net_setup_aneg(card);
> > mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> >
> > @@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
> > goto init_firmware_failed;
> >
> > /* start probing with copper */
> > + card->aneg_count = 0;
> > + card->medium = BCM54XX_COPPER;
> > spider_net_setup_aneg(card);
> > if (card->phy.def->phy_id)
> > mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> > _______________________________________________
> > cbe-oss-dev mailing list
> > cbe-oss-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/cbe-oss-dev
> >
--
Gruß,
Jens
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/5] spidernet: add missing initialization
@ 2008-04-11 3:27 Ishizaki Kou
2008-04-12 9:01 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Ishizaki Kou @ 2008-04-11 3:27 UTC (permalink / raw)
To: jgarzik; +Cc: jens, netdev, cbe-oss-dev
This patch fixes initialization of "aneg_count" and "medium" fields in
spider_net_card to make spidernet driver correctly sets "link status".
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Jens Osterkamp <jens@de.ibm.com>
---
Jeff-san,
Could you consider these spidernet patches for 2.6.26?
Best regards,
Kou Ishizaki
Index: linux-powerpc-git/drivers/net/spider_net.c
===================================================================
--- linux-powerpc-git.orig/drivers/net/spider_net.c
+++ linux-powerpc-git/drivers/net/spider_net.c
@@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device
spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
/* reset phy and setup aneg */
+ card->aneg_count = 0;
+ card->medium = BCM54XX_COPPER;
spider_net_setup_aneg(card);
mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
@@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
goto init_firmware_failed;
/* start probing with copper */
+ card->aneg_count = 0;
+ card->medium = BCM54XX_COPPER;
spider_net_setup_aneg(card);
if (card->phy.def->phy_id)
mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/5] spidernet: add missing initialization
2008-04-11 3:27 Ishizaki Kou
@ 2008-04-12 9:01 ` Jeff Garzik
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2008-04-12 9:01 UTC (permalink / raw)
To: Ishizaki Kou; +Cc: jens, netdev, cbe-oss-dev
Ishizaki Kou wrote:
> This patch fixes initialization of "aneg_count" and "medium" fields in
> spider_net_card to make spidernet driver correctly sets "link status".
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Acked-by: Jens Osterkamp <jens@de.ibm.com>
> ---
>
> Jeff-san,
>
> Could you consider these spidernet patches for 2.6.26?
>
> Best regards,
> Kou Ishizaki
applied 1-5
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-04-12 9:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-11 6:38 [PATCH 1/5] spidernet: add missing initialization Ishizaki Kou
2008-01-11 12:44 ` Jens Osterkamp
2008-01-11 16:48 ` Linas Vepstas
2008-01-12 22:52 ` Jeff Garzik
2008-01-17 10:22 ` Ishizaki Kou
2008-01-23 13:53 ` [Cbe-oss-dev] " Jens Osterkamp
2008-01-28 13:40 ` Jens Osterkamp
-- strict thread matches above, loose matches on Subject: below --
2008-04-11 3:27 Ishizaki Kou
2008-04-12 9:01 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).