netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org
Subject: Re: [X25]: Avoid divides and sparse warnings
Date: Sun, 13 Jan 2008 22:29:07 -0800 (PST)	[thread overview]
Message-ID: <20080113.222907.152771528.davem@davemloft.net> (raw)
In-Reply-To: <4789E8DD.2020901@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sun, 13 Jan 2008 11:33:01 +0100

>    CHECK   net/x25/af_x25.c
> net/x25/af_x25.c:117:46: warning: expensive signed divide
>    CHECK   net/x25/x25_facilities.c
> net/x25/x25_facilities.c:209:30: warning: expensive signed divide
>    CHECK   net/x25/x25_in.c
> net/x25/x25_in.c:250:26: warning: expensive signed divide
>    CHECK   net/x25/x25_proc.c
> net/x25/x25_proc.c:48:11: warning: context imbalance in 'x25_seq_route_start' 
> - wrong count at exit
> net/x25/x25_proc.c:72:13: warning: context imbalance in 'x25_seq_route_stop' - 
> unexpected unlock
> net/x25/x25_proc.c:112:11: warning: context imbalance in 
> 'x25_seq_socket_start' - wrong count at exit
> net/x25/x25_proc.c:129:13: warning: context imbalance in 'x25_seq_socket_stop' 
> - unexpected unlock
> net/x25/x25_proc.c:190:11: warning: context imbalance in 
> 'x25_seq_forward_start' - wrong count at exit
> net/x25/x25_proc.c:215:13: warning: context imbalance in 
> 'x25_seq_forward_stop' - unexpected unlock
>    CHECK   net/x25/x25_subr.c
> net/x25/x25_subr.c:362:57: warning: expensive signed divide
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

Applied, thanks Eric.

We might just want to make sk_rcvbuf et al. unsigned, it
crops up a lot and I can't see any valid reason for it
to be negative or for uses of it to matter with other
signed values.

Or did we discuss that to death already? :-)

      reply	other threads:[~2008-01-14  6:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13 10:33 [X25]: Avoid divides and sparse warnings Eric Dumazet
2008-01-14  6:29 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080113.222907.152771528.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).