From: Andi Kleen <ak@suse.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, linux-kerne@vger.kernel.org
Subject: Re: [PATCH/RFC] synchronize_rcu(): high latency on idle system
Date: Sun, 13 Jan 2008 16:34:17 +0100 [thread overview]
Message-ID: <200801131634.17677.ak@suse.de> (raw)
In-Reply-To: <20080112175226.7d8f9dbc@deepthought>
> I think it should be in netdev_unregister_kobject(). But that would
> only get rid of one of the two calls to synchronize_rcu() in the unregister_netdev.
Would be already an improvement.
> The other synchronize_rcu() is for qdisc's and not sure if that one can
> be removed?
The standard way to remove such calls is to set a "deleted" flag in the object,
then check and ignore such objects in the reader and finally remove the object with
call_rcu
I have not checked if that is really feasible for qdiscs.
-Andi
next prev parent reply other threads:[~2008-01-13 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080112012626.GI28570@kvack.org>
[not found] ` <20080112023759.GG21068@bingen.suse.de>
[not found] ` <20080112175135.GK28570@kvack.org>
[not found] ` <200801121935.58286.ak@suse.de>
2008-01-13 1:52 ` [PATCH/RFC] synchronize_rcu(): high latency on idle system Stephen Hemminger
2008-01-13 15:34 ` Andi Kleen [this message]
2008-01-14 17:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801131634.17677.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kerne@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).