netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Cliburn <jacliburn@bellsouth.net>
To: jeff@garzik.org, davem@davemloft.net
Cc: Jay Cliburn <jacliburn@bellsouth.net>,
	csnook@redhat.com, david.harris@cpni-inc.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] atl1: fix frame length bug
Date: Mon, 14 Jan 2008 20:04:28 -0600	[thread overview]
Message-ID: <20080114200428.1c62e8fb@osprey.hogchain.net> (raw)
In-Reply-To: <1200362201-30987-1-git-send-email-jacliburn@bellsouth.net>

On Mon, 14 Jan 2008 19:56:41 -0600
Jay Cliburn <jacliburn@bellsouth.net> wrote:

> The driver sets up the hardware to accept a frame with max length
> equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to
> add the VLAN tag size to the ingress buffer.  When a VLAN-tagged
> frame arrives, the hardware passes it, but bad things happen
> because the buffer is too small.  This patch fixes that.
> 
> Thanks to David Harris for reporting the bug and testing the fix.
> 
> Tested-by: David Harris <david.harris@cpni-inc.com>
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>

Jeff, Dave,

This bugfix needs to go in for 2.6.24 if possible.

Thanks,
Jay

  reply	other threads:[~2008-01-15  2:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15  1:56 [PATCH] atl1: fix frame length bug Jay Cliburn
2008-01-15  2:04 ` Jay Cliburn [this message]
2008-01-18 12:52   ` Jay Cliburn
2008-01-18 19:42 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080114200428.1c62e8fb@osprey.hogchain.net \
    --to=jacliburn@bellsouth.net \
    --cc=csnook@redhat.com \
    --cc=davem@davemloft.net \
    --cc=david.harris@cpni-inc.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).