From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: devik@cdi.cz, slavon@bigtelecom.ru, netdev@vger.kernel.org
Subject: Re: Not understand some in htb_do_events function
Date: Tue, 15 Jan 2008 21:07:29 -0800 (PST) [thread overview]
Message-ID: <20080115.210729.128392129.davem@davemloft.net> (raw)
In-Reply-To: <478CD741.7040004@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 15 Jan 2008 16:54:41 +0100
> Martin Devera wrote:
> > to drain extra events asap. It the time of writing I was not able to
> > come with better solution and there were more bugs related to this
> > part of code than now.
>
> So this was meant to protect against endless loops?
I think, as Martin tried to explain further, it's trying
to avoid cases where the amount of work is extremely large.
Heuristics like this are by definition going to hit cases
where the value chosen is wrong or inappropriate. On fast
cpus maybe a value of 50000 instead of 500 would work "best"
Therefore I would suggest removing the limit altogether for now and in
the long term work on whatever deficiencies in the algorithm make this
expensive enough to warrant limits in the first place.
prev parent reply other threads:[~2008-01-16 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 10:11 Not understand some in htb_do_events function Badalian Vyacheslav
2008-01-15 10:15 ` Patrick McHardy
2008-01-15 11:59 ` Martin Devera
2008-01-15 13:51 ` Badalian Vyacheslav
2008-01-15 13:54 ` Martin Devera
2008-01-15 15:54 ` Patrick McHardy
2008-01-15 21:58 ` Martin Devera
2008-01-16 5:15 ` Patrick McHardy
2008-01-16 5:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115.210729.128392129.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devik@cdi.cz \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=slavon@bigtelecom.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).