From: Jarek Poplawski <jarkao2@gmail.com>
To: Makito SHIOKAWA <mshiokawa@miraclelinux.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] bonding: Fix work initing and cancelling
Date: Tue, 15 Jan 2008 11:56:01 +0100 [thread overview]
Message-ID: <20080115105601.GC1696@ff.dom.local> (raw)
In-Reply-To: <20080115063649.961619000@miraclelinux.com>
On 15-01-2008 07:36, Makito SHIOKAWA wrote:
...
> --- a/drivers/net/bonding/bond_sysfs.c
> +++ b/drivers/net/bonding/bond_sysfs.c
> @@ -643,10 +643,8 @@ static ssize_t bonding_store_arp_interva
> "%s Disabling MII monitoring.\n",
> bond->dev->name, bond->dev->name);
> bond->params.miimon = 0;
> - if (delayed_work_pending(&bond->mii_work)) {
> - cancel_delayed_work(&bond->mii_work);
> - flush_workqueue(bond->wq);
> - }
> + cancel_delayed_work(&bond->mii_work);
> + flush_workqueue(bond->wq);
I wonder why don't you use cancel_delayed_work_sync() here (and in a
few other places), like in bond_work_cancel_all() from patch 2/4?
Regards,
Jarek P.
next prev parent reply other threads:[~2008-01-15 10:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 6:36 [PATCH 0/4] bonding: Fix workqueue manipulation and lock taking Makito SHIOKAWA
2008-01-15 6:36 ` [PATCH 1/4] bonding: Fix work initing and cancelling Makito SHIOKAWA
2008-01-15 10:56 ` Jarek Poplawski [this message]
2008-01-16 5:17 ` Makito SHIOKAWA
2008-01-15 6:36 ` [PATCH 2/4] bonding: Add destroy_workqueue() to bond device destroying process Makito SHIOKAWA
2008-01-15 6:36 ` [PATCH 3/4] bonding: Fix work rearming Makito SHIOKAWA
2008-01-15 9:05 ` Jarek Poplawski
2008-01-16 3:19 ` Makito SHIOKAWA
2008-01-16 13:36 ` Jarek Poplawski
2008-01-17 5:30 ` Makito SHIOKAWA
2008-01-17 11:18 ` Jarek Poplawski
2008-01-18 13:43 ` Makito SHIOKAWA
2008-01-18 22:27 ` Jarek Poplawski
2008-01-18 22:43 ` Jarek Poplawski
2008-01-21 4:04 ` Makito SHIOKAWA
2008-01-21 13:33 ` Jarek Poplawski
2008-01-22 3:35 ` Makito SHIOKAWA
2008-01-16 3:28 ` Makito SHIOKAWA
2008-01-15 6:36 ` [PATCH 4/4] bonding: Fix some RTNL taking Makito SHIOKAWA
2008-01-16 12:44 ` Jarek Poplawski
2008-01-17 5:30 ` Makito SHIOKAWA
2008-01-17 11:46 ` Jarek Poplawski
2008-01-18 9:06 ` Makito SHIOKAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115105601.GC1696@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=mshiokawa@miraclelinux.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).