netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org, stephen.hemminger@vyatta.com,
	herbert@gondor.apana.org.au
Subject: Re: [FIB]: Fix rcu_dereference() abuses in fib_trie.c
Date: Fri, 18 Jan 2008 03:31:53 -0800 (PST)	[thread overview]
Message-ID: <20080118.033153.235763392.davem@davemloft.net> (raw)
In-Reply-To: <20080115092940.311fb2c3.dada1@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue, 15 Jan 2008 09:29:40 +0100

> node_parent() and tnode_get_child() currently use rcu_dereference().
> 
> These functions are called from both 
> - readers only paths (where rcu_dereference() is needed), and 
> - writer path (where rcu_dereference() is not needed)
> 
> To make explicit where rcu_dereference() is really needed, I introduced
> new node_parent_rcu() and tnode_get_child_rcu() functions which use
> rcu_dereference(), while node_parent() and tnode_get_child() dont use it.
> 
> Then I changed calling sites where rcu_dereference() was really needed to
> call the _rcu() variants.
> 
> This should have no impact but for alpha architecture, and may help future
> sparse checks.
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

Applied to net-2.6.25, thanks Eric.

      reply	other threads:[~2008-01-18 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15  8:29 [FIB]: Fix rcu_dereference() abuses in fib_trie.c Eric Dumazet
2008-01-18 11:31 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118.033153.235763392.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=stephen.hemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).