Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org, Robert.Olsson@data.slu.se
Subject: Re: [IPV4] FIB_HASH : Avoid unecessary loop in fn_hash_dump_zone()
Date: Fri, 18 Jan 2008 04:30:45 -0800 (PST)	[thread overview]
Message-ID: <20080118.043045.23272694.davem@davemloft.net> (raw)
In-Reply-To: <20080116181925.2c5c540f.dada1@cosmosbay.com>

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Wed, 16 Jan 2008 18:19:25 +0100

> I noticed "ip route list" was slower than "cat /proc/net/route" on a machine with a full Internet
> routing table (214392 entries : Special thanks to Robert ;) )
> 
> This is similar to problem reported in commit d8c9283089287341c85a0a69de32c2287a990e71
> 
> Fix is to avoid scanning the begining of fz_hash table, but directly seek to the right offset.
> 
> Before patch :
> 
> time ip route >/tmp/ROUTE
> 
> real    0m1.285s
> user    0m0.712s
> sys     0m0.436s
> 
> After patch
> 
> # time ip route >/tmp/ROUTE
> 
> real    0m0.835s
> user    0m0.692s
> sys     0m0.124s
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

Applied, thanks Eric.

      reply	other threads:[~2008-01-18 12:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 17:19 [IPV4] FIB_HASH : Avoid unecessary loop in fn_hash_dump_zone() Eric Dumazet
2008-01-18 12:30 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118.043045.23272694.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Robert.Olsson@data.slu.se \
    --cc=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox