From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= Subject: Re: [PATCH] IPv4: Enable use of 240/4 address space Date: Fri, 18 Jan 2008 10:26:35 +0900 (JST) Message-ID: <20080118.102635.01689255.yoshfuji@linux-ipv6.org> References: <20080108011057.GA21168@cisco.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ak@suse.de, vaf@cisco.com, yoshfuji@linux-ipv6.org To: jengelh@computergmbh.de Return-path: Received: from yue.linux-ipv6.org ([203.178.140.15]:35489 "EHLO yue.st-paulia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758858AbYARB0Z (ORCPT ); Thu, 17 Jan 2008 20:26:25 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: In article (at Fri, 18 Jan 2008 02:13:52 +0100 (CET)), Jan Engelhardt says: > diff --git a/include/linux/in.h b/include/linux/in.h > index 27d8a5a..b01bf75 100644 > --- a/include/linux/in.h > +++ b/include/linux/in.h > @@ -216,9 +216,6 @@ struct sockaddr_in { > #define IN_MULTICAST(a) IN_CLASSD(a) > #define IN_MULTICAST_NET 0xF0000000 > > -#define IN_EXPERIMENTAL(a) ((((long int) (a)) & 0xf0000000) == 0xf0000000) > -#define IN_BADCLASS(a) IN_EXPERIMENTAL((a)) > - > /* Address to accept any incoming messages. */ > #define INADDR_ANY ((unsigned long int) 0x00000000) > No, please keep these macros. > @@ -264,7 +261,7 @@ static inline bool ipv4_is_local_multicast(__be32 addr) > > static inline bool ipv4_is_badclass(__be32 addr) > { > - return (addr & htonl(0xf0000000)) == htonl(0xf0000000); > + return addr == 0xFFFFFFFF; > } > To (un)align the IN_BADCLASS macro and ipv6_is_badclass() definition, you should change the name anyway, e.g., ipv6_is_limited_broadcast() or some something alike. --yoshfuji