From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: chas@cmf.nrl.navy.mil, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] atm/suni.c: fix section mismatch
Date: Sat, 19 Jan 2008 14:29:04 +0100 [thread overview]
Message-ID: <20080119132904.GC26615@uranus.ravnborg.org> (raw)
In-Reply-To: <20080119131851.GB8669@does.not.exist>
On Sat, Jan 19, 2008 at 03:18:51PM +0200, Adrian Bunk wrote:
> EXPORT_SYMBOL'ed code mustn't be __*init.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> ---
> --- linux-2.6/drivers/atm/suni.c.old 2008-01-19 12:16:41.000000000 +0200
> +++ linux-2.6/drivers/atm/suni.c 2008-01-19 12:17:23.000000000 +0200
> @@ -275,35 +275,35 @@ static int suni_stop(struct atm_dev *dev
> *walk = PRIV((*walk)->dev)->next;
> if (!sunis) del_timer_sync(&poll_timer);
> spin_unlock_irqrestore(&sunis_lock,flags);
> kfree(PRIV(dev));
>
> return 0;
> }
>
>
> static const struct atmphy_ops suni_ops = {
> .start = suni_start,
> .ioctl = suni_ioctl,
> .interrupt = suni_int,
> .stop = suni_stop,
> };
>
>
> -int __devinit suni_init(struct atm_dev *dev)
> +int suni_init(struct atm_dev *dev)
> {
> unsigned char mri;
>
> mri = GET(MRI); /* reset SUNI */
> PUT(mri | SUNI_MRI_RESET,MRI);
> PUT(mri,MRI);
> PUT((GET(MT) & SUNI_MT_DS27_53),MT); /* disable all tests */
> REG_CHANGE(SUNI_TPOP_APM_S,SUNI_TPOP_APM_S_SHIFT,SUNI_TPOP_S_SONET,
> TPOP_APM); /* use SONET */
> REG_CHANGE(SUNI_TACP_IUCHP_CLP,0,SUNI_TACP_IUCHP_CLP,
> TACP_IUCHP); /* idle cells */
> PUT(SUNI_IDLE_PATTERN,TACP_IUCPOP);
> dev->phy = &suni_ops;
> return 0;
> }
>
> EXPORT_SYMBOL(suni_init);
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-01-19 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-19 13:18 [2.6 patch] atm/suni.c: fix section mismatch Adrian Bunk
2008-01-19 13:29 ` Sam Ravnborg [this message]
2008-01-21 1:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080119132904.GC26615@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@kernel.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).