* [PATCH] ipv6: addrconf sparse warnings
@ 2008-01-20 18:01 Stephen Hemminger
2008-01-21 8:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2008-01-20 18:01 UTC (permalink / raw)
To: David Miller,
YOSHIFUJI Hideaki / 吉藤英明; +Cc: netdev
Get rid of a couple of sparse warnings in IPV6 addrconf code.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/ipv6/addrconf.c 2008-01-20 09:38:06.000000000 -0800
+++ b/net/ipv6/addrconf.c 2008-01-20 09:57:40.000000000 -0800
@@ -1900,7 +1900,7 @@ int addrconf_set_dstaddr(void __user *ar
p.iph.ihl = 5;
p.iph.protocol = IPPROTO_IPV6;
p.iph.ttl = 64;
- ifr.ifr_ifru.ifru_data = (void __user *)&p;
+ ifr.ifr_ifru.ifru_data = (__force void __user *)&p;
oldfs = get_fs(); set_fs(KERNEL_DS);
err = dev->do_ioctl(dev, &ifr, SIOCADDTUNNEL);
@@ -2799,6 +2799,7 @@ static struct inet6_ifaddr *if6_get_idx(
}
static void *if6_seq_start(struct seq_file *seq, loff_t *pos)
+ __acquires(addrconf_hash_lock)
{
read_lock_bh(&addrconf_hash_lock);
return if6_get_idx(seq, *pos);
@@ -2814,6 +2815,7 @@ static void *if6_seq_next(struct seq_fil
}
static void if6_seq_stop(struct seq_file *seq, void *v)
+ __releases(addrconf_hash_lock)
{
read_unlock_bh(&addrconf_hash_lock);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: addrconf sparse warnings
2008-01-20 18:01 [PATCH] ipv6: addrconf sparse warnings Stephen Hemminger
@ 2008-01-21 8:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-21 8:48 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sun, 20 Jan 2008 10:01:40 -0800
> Get rid of a couple of sparse warnings in IPV6 addrconf code.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-21 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-20 18:01 [PATCH] ipv6: addrconf sparse warnings Stephen Hemminger
2008-01-21 8:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).