netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: josh@freedesktop.org
Cc: paulmck@linux.vnet.ibm.com, shemminger@vyatta.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: add sparse annotation to ptype_seq_start/stop
Date: Mon, 21 Jan 2008 02:28:21 -0800 (PST)	[thread overview]
Message-ID: <20080121.022821.56278182.davem@davemloft.net> (raw)
In-Reply-To: <479449DC.4020105@freedesktop.org>

From: Josh Triplett <josh@freedesktop.org>
Date: Sun, 20 Jan 2008 23:29:32 -0800

> At the moment, Sparse doesn't actually use the context expression.  In
> the ideal case when it does, all references to the same lock should
> use a context expression which resolves to that lock (whatever that
> may mean; hence why Sparse doesn't handle it yet).  For mechanisms
> like RCU without a lock variable, this will likely entail some sort of
> fake lock expression, which again needs to match between all users of
> the same mechanism.  Like any expression in C, case matters; thus,
> please match the existing references to "RCU" rather than "rcu".

Thus, I've checked in Stephen's patch with __acquires(RCU) and
__releases(RCU).

Thanks.


      reply	other threads:[~2008-01-21 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-20 23:21 [PATCH] net: add sparse annotation to ptype_seq_start/stop Stephen Hemminger
2008-01-21  5:03 ` Paul E. McKenney
2008-01-21  5:28   ` Al Viro
2008-01-21  6:01     ` Paul E. McKenney
2008-01-21  7:29   ` Josh Triplett
2008-01-21 10:28     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080121.022821.56278182.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=josh@freedesktop.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).