From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: netdev@vger.kernel.org, slavon@bigtelecom.ru, kaber@trash.net,
hadi@cyberus.ca
Subject: Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator
Date: Mon, 21 Jan 2008 02:35:15 -0800 (PST) [thread overview]
Message-ID: <20080121.023515.256390630.davem@davemloft.net> (raw)
In-Reply-To: <20080120234659.GA2691@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 21 Jan 2008 00:46:59 +0100
I like the technique you used to fix this bug, but:
> diff -Nurp 2.6.24-rc8-mm1-/include/linux/gen_stats.h 2.6.24-rc8-mm1+/include/linux/gen_stats.h
> --- 2.6.24-rc8-mm1-/include/linux/gen_stats.h 2007-10-09 22:31:38.000000000 +0200
> +++ 2.6.24-rc8-mm1+/include/linux/gen_stats.h 2008-01-20 20:37:08.000000000 +0100
> @@ -28,11 +28,13 @@ struct gnet_stats_basic
> * struct gnet_stats_rate_est - rate estimator
> * @bps: current byte rate
> * @pps: current packet rate
> + * @gen_estimator: internal data
> */
> struct gnet_stats_rate_est
> {
> __u32 bps;
> __u32 pps;
> + unsigned long gen_estimator;
> };
>
> /**
Sorry, this structure is exported to userspace so we can't
change it like that.
It is an attribute passed over netlink sockets.
next prev parent reply other threads:[~2008-01-21 10:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 23:46 [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator Jarek Poplawski
2008-01-21 10:35 ` David Miller [this message]
2008-01-21 10:56 ` Jarek Poplawski
2008-01-21 22:31 ` [PATCH 1/3 v2][NET] " Jarek Poplawski
2008-01-21 22:41 ` Jarek Poplawski
2008-01-22 0:29 ` David Miller
2008-01-22 7:21 ` Jarek Poplawski
2008-01-22 7:26 ` Jarek Poplawski
2008-01-22 11:42 ` jamal
2008-01-22 12:29 ` Jarek Poplawski
2008-01-22 13:54 ` jamal
2008-01-22 19:22 ` Jarek Poplawski
2008-01-25 22:00 ` [PATCH v3][NET] " Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121.023515.256390630.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=slavon@bigtelecom.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).