From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: shemminger@linux-foundation.org, slavon@bigtelecom.ru,
kaber@trash.net, hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed
Date: Mon, 21 Jan 2008 02:36:32 -0800 (PST) [thread overview]
Message-ID: <20080121.023632.122420355.davem@davemloft.net> (raw)
In-Reply-To: <20080121064240.GB981@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 21 Jan 2008 07:42:40 +0100
> On Mon, Jan 21, 2008 at 07:34:55AM +0100, Jarek Poplawski wrote:
> ...
> > BTW, I've forgotten to mention with patch 1/3 that this checking with
> > warning on gen_new_estimator() double call should be only temporary,
> > and after more testing gen_estimator structure could be probably
> > decreased after removing bstats and rate_est fields.
>
> Hmm, let's forget about this again: it's too early in the morning...
:-)
FWIW I agree that double-negatives are confusing and we should
avoid them.
next prev parent reply other threads:[~2008-01-21 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 23:49 [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed Jarek Poplawski
2008-01-20 23:55 ` Stephen Hemminger
2008-01-21 6:34 ` Jarek Poplawski
2008-01-21 6:42 ` Jarek Poplawski
2008-01-21 10:36 ` David Miller [this message]
2008-01-21 11:19 ` Jarek Poplawski
2008-01-21 11:15 ` David Miller
2008-01-21 11:28 ` Jarek Poplawski
2008-01-21 14:43 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080121.023632.122420355.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=slavon@bigtelecom.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).