* [IPV4] igmp sparse warnings
@ 2008-01-21 17:52 Stephen Hemminger
2008-01-22 1:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2008-01-21 17:52 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Partial sparse warning fix. The other conditional locking
is too much for sparse to handle.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/ipv4/igmp.c 2008-01-21 09:35:58.000000000 -0800
+++ b/net/ipv4/igmp.c 2008-01-21 09:36:20.000000000 -0800
@@ -2329,6 +2329,7 @@ static struct ip_mc_list *igmp_mc_get_id
}
static void *igmp_mc_seq_start(struct seq_file *seq, loff_t *pos)
+ __acquires(dev_base_lock)
{
read_lock(&dev_base_lock);
return *pos ? igmp_mc_get_idx(seq, *pos - 1) : SEQ_START_TOKEN;
@@ -2346,6 +2347,7 @@ static void *igmp_mc_seq_next(struct seq
}
static void igmp_mc_seq_stop(struct seq_file *seq, void *v)
+ __releases(dev_base_lock)
{
struct igmp_mc_iter_state *state = igmp_mc_seq_private(seq);
if (likely(state->in_dev != NULL)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [IPV4] igmp sparse warnings
2008-01-21 17:52 [IPV4] igmp sparse warnings Stephen Hemminger
@ 2008-01-22 1:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-01-22 1:28 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 21 Jan 2008 09:52:17 -0800
> Partial sparse warning fix. The other conditional locking
> is too much for sparse to handle.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-22 1:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-21 17:52 [IPV4] igmp sparse warnings Stephen Hemminger
2008-01-22 1:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).