From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [GIT PULL] [IPV6,IPV4]: Fix several sparse warnings.
Date: Tue, 22 Jan 2008 02:44:19 -0800 (PST) [thread overview]
Message-ID: <20080122.024419.39724872.davem@davemloft.net> (raw)
In-Reply-To: <20080122110312.10445043.dada1@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue, 22 Jan 2008 11:03:12 +0100
> On Tue, 22 Jan 2008 18:56:32 +0900 (JST)
> YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> wrote:
>
> > @@ -418,7 +418,7 @@ out:
> >
> > void udp_err(struct sk_buff *skb, u32 info)
> > {
> > - return __udp4_lib_err(skb, info, udp_hash);
> > + __udp4_lib_err(skb, info, udp_hash);
> > }
>
> Hum... On this one, I would say Sparse is picky, not to say buggy :(
Agreed, but making this change is harmless :-)
next prev parent reply other threads:[~2008-01-22 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 9:56 [GIT PULL] [IPV6,IPV4]: Fix several sparse warnings YOSHIFUJI Hideaki / 吉藤英明
2008-01-22 10:03 ` Eric Dumazet
2008-01-22 10:44 ` David Miller [this message]
2008-01-22 10:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122.024419.39724872.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).