From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [INET]: Fix truesize setting in ip_append_data
Date: Tue, 22 Jan 2008 21:47:19 -0800 (PST) [thread overview]
Message-ID: <20080122.214719.168781298.davem@davemloft.net> (raw)
In-Reply-To: <20080123033942.GA698@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 23 Jan 2008 14:39:42 +1100
> [INET]: Fix truesize setting in ip_append_data
>
> As it is ip_append_data only counts page fragments to the skb that
> allocated it. As such it means that the first skb gets hit with a
> 4K charge even though it might have only used a fraction of it while
> all subsequent skb's that use the same page gets away with no charge
> at all.
>
> This bug was exposed by the UDP accounting patch.
>
> This patch also fixes a similar bug in ip_append_page spotted by you :)
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
I added this to net-2.6, thanks Herbert!
I already checked in the ip_append_page() fix to net-2.6 so
I simply removed that hunk when adding your fix.
Thanks again!
next prev parent reply other threads:[~2008-01-23 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 3:39 [INET]: Fix truesize setting in ip_append_data Herbert Xu
2008-01-23 5:47 ` David Miller [this message]
2008-01-23 6:41 ` Herbert Xu
2008-01-23 6:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122.214719.168781298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox