From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Cliburn Subject: Re: [PATCH 06/26] atl1: update initialization parameters Date: Tue, 22 Jan 2008 20:13:46 -0600 Message-ID: <20080122201346.6bb36ca2@osprey.hogchain.net> References: <1199152804-3889-1-git-send-email-jacliburn@bellsouth.net> <1199152804-3889-7-git-send-email-jacliburn@bellsouth.net> <4795BDBB.10904@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: csnook@redhat.com, linux-kernel@vger.kernel.org, atl1-devel@lists.sourceforge.net, netdev@vger.kernel.org To: Jeff Garzik Return-path: Received: from fmailhost01.isp.att.net ([204.127.217.101]:51727 "EHLO fmailhost01.isp.att.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbYAWCNt (ORCPT ); Tue, 22 Jan 2008 21:13:49 -0500 In-Reply-To: <4795BDBB.10904@garzik.org> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 22 Jan 2008 04:56:11 -0500 Jeff Garzik wrote: > jacliburn@bellsouth.net wrote: > > From: Jay Cliburn > > > > Update initialization parameters to match the current vendor driver > > version 1.2.40.2. [...] > ACK without any better knowledge... but is any addition insight > available at all? No, sorry Jeff. I simply took the vendor's current driver and matched his initialization settings. I can only assume he discovered these values through lab testing. For this and the other "conform to vendor driver" patches in this set, I thought it important to have the in-tree driver match the vendor driver as closely as possible. The primary motivations are (1) my belief that he's in a better position to test the NIC, and (2) to be able to go to him for assistance occasionally and not be rejected because of significant differences between his and our drivers. Jay