From: Jens Osterkamp <jens@de.ibm.com>
To: cbe-oss-dev@ozlabs.org
Cc: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>, netdev@vger.kernel.org
Subject: Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization
Date: Wed, 23 Jan 2008 14:53:42 +0100 [thread overview]
Message-ID: <200801231453.42736.jens@de.ibm.com> (raw)
In-Reply-To: <20080111.153859.-1300526764.kouish@swc.toshiba.co.jp>
On Friday 11 January 2008, Ishizaki Kou wrote:
> This patch fixes initialization of "aneg_count" and "medium" fields in
> spider_net_card to make spidernet driver correctly sets "link status".
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Jens Osterkamp <jens@de.ibm.com>
> ---
>
> Index: linux-powerpc-git/drivers/net/spider_net.c
> ===================================================================
> --- linux-powerpc-git.orig/drivers/net/spider_net.c
> +++ linux-powerpc-git/drivers/net/spider_net.c
> @@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device
> spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
>
> /* reset phy and setup aneg */
> + card->aneg_count = 0;
> + card->medium = BCM54XX_COPPER;
> spider_net_setup_aneg(card);
> mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
>
> @@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
> goto init_firmware_failed;
>
> /* start probing with copper */
> + card->aneg_count = 0;
> + card->medium = BCM54XX_COPPER;
> spider_net_setup_aneg(card);
> if (card->phy.def->phy_id)
> mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev
>
--
Gruß,
Jens
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2008-01-23 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 6:38 [PATCH 1/5] spidernet: add missing initialization Ishizaki Kou
2008-01-11 12:44 ` Jens Osterkamp
2008-01-11 16:48 ` Linas Vepstas
2008-01-12 22:52 ` Jeff Garzik
2008-01-17 10:22 ` Ishizaki Kou
2008-01-23 13:53 ` Jens Osterkamp [this message]
2008-01-28 13:40 ` [Cbe-oss-dev] " Jens Osterkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801231453.42736.jens@de.ibm.com \
--to=jens@de.ibm.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).