From: Joonwoo Park <joonwpark81@gmail.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: "David S. Miller" <davem@davemloft.net>,
Robert Olsson <robert.olsson@data.slu.se>,
netdev@vger.kernel.org, Joonwoo Park <joonwpark81@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jarek Poplawski <jarkao2@gmail.com>,
schwab@suse.de
Subject: Re: [PATCH 2.6.24] fib_trie: apply fixes from fib_hash
Date: Sat, 26 Jan 2008 14:18:15 +0900 [thread overview]
Message-ID: <20080126051815.GA17278@ehus.geninetworks.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0801260427400.12635@u.domain.uli>
On Sat, Jan 26, 2008 at 04:40:30AM +0200, Julian Anastasov wrote:
>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
> ---
>
> Not tested, someone please check the findings
>
> --- linux-2.6.24/net/ipv4/fib_trie.c_orig 2008-01-25 10:45:06.000000000 +0200
> +
> if (cfg->fc_nlflags & NLM_F_REPLACE) {
> struct fib_info *fi_drop;
> u8 state;
>
> - if (fi->fib_treeref > 1)
> + fa = fa_first;
> + if (fa_match && fa != fa_match)
> goto out;
> -
Isn't it possible to do this (fib_hash too)?
if (fa_match) {
if (fa != fa_match)
return 0;
goto out;
}
Thanks,
Joonwoo
next prev parent reply other threads:[~2008-01-26 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 2:40 [PATCH 2.6.24] fib_trie: apply fixes from fib_hash Julian Anastasov
2008-01-26 5:18 ` Joonwoo Park [this message]
2008-01-26 5:20 ` Joonwoo Park
2008-01-26 9:46 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126051815.GA17278@ehus.geninetworks.com \
--to=joonwpark81@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@data.slu.se \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).