From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: iproute2 (addr flush) infinite loop when unprivileged users Date: Sat, 26 Jan 2008 11:14:37 -0800 Message-ID: <20080126111437.2669236e@deepthought> References: <9e0cf0bf0801251500u388b9a5dxda92d6d1e3d86233@mail.gmail.com> <20080125161259.0356c990@deepthought> <9e0cf0bf0801251622w203c515fn80cba5f233bd599d@mail.gmail.com> <9e0cf0bf0801260058s797d2ea3r7af013d0957554d8@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: "Alon Bar-Lev" Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:57694 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbYAZTOv (ORCPT ); Sat, 26 Jan 2008 14:14:51 -0500 In-Reply-To: <9e0cf0bf0801260058s797d2ea3r7af013d0957554d8@mail.gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 26 Jan 2008 10:58:58 +0200 "Alon Bar-Lev" wrote: > On 1/26/08, Alon Bar-Lev wrote: > > On 1/26/08, Stephen Hemminger wrote: > > > The issue is that iproute is just blindly sending the deletes and > > > not asking for acknowledgment status. Here is a trivial patch to iproute > > > to fix that, but the problem is that it means it will slow down bulk removal. > > > > > > Maybe it should just check the first, or last delete to see if there are > > > errors? > > > > > > diff --git a/ip/iproute.c b/ip/iproute.c > > > index 7a885b0..b2ae879 100644 > > > --- a/ip/iproute.c > > > +++ b/ip/iproute.c > > > > This should also be applied into ip/ipaddress.c, ip/ipneigh.c > > Or even make one common function? > > > > I don't quite understand how "fast" is good if not complete... But > > anyway... I will be happy to see this fix in next version... Maybe add > > --fast argument? :) > > > > Alon. > > > > Pulled your latest git head. See some updates but not this one... > Just thought to report the following [new] build error: > > > gcc -Wl,-export-dynamic ip.o ipaddress.o iproute.o iprule.o rtm_map.o > iptunnel.o ip6tunnel.o tunnel.o ipneigh.o ipntable.o iplink.o > ipmaddr.o ipmonitor.o ipmroute.o ipprefix.o ipxfrm.o xfrm_state.o > xfrm_policy.o xfrm_monitor.o iplink_vlan.o link_veth.o > ../lib/libnetlink.a ../lib/libutil.a -lresolv -L../lib -lnetlink > -lutil -ldl -o ip > iptunnel.o: In function `parse_args': > iptunnel.c:(.text+0x2f6): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x434): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x4c1): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x4da): undefined reference to `__constant_htons' > iptunnel.c:(.text+0x51c): undefined reference to `__constant_htons' > iptunnel.o:iptunnel.c:(.text+0x535): more undefined references to > `__constant_htons' follow > collect2: ld returned 1 exit status > make[1]: *** [ip] Error 1 What system are you building on. This is defined in linux/byteorder.h -- Stephen Hemminger