From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: mitch@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.25] [IPV6] ADDRLABEL: Fix double free on label deletion.
Date: Mon, 28 Jan 2008 16:21:04 -0800 (PST) [thread overview]
Message-ID: <20080128.162104.132600552.davem@davemloft.net> (raw)
In-Reply-To: <20080128.210222.07062540.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Mon, 28 Jan 2008 21:02:22 +0900 (JST)
> If an entry is being deleted because it has only one reference,
> we immediately delete it and blindly register the rcu handler for it,
> This results in oops by double freeing that object.
>
> This patch fixes it by consolidating the code paths for the deletion;
> let its rcu handler delete the object if it has no more reference.
>
> Bug was found by Mitsuru Chinen <mitch@linux.vnet.ibm.com>
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied, thank you.
next prev parent reply other threads:[~2008-01-29 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 12:02 [PATCH net-2.6.25] [IPV6] ADDRLABEL: Fix double free on label deletion YOSHIFUJI Hideaki / 吉藤英明
2008-01-29 0:21 ` David Miller [this message]
2008-01-29 20:59 ` Paul E. McKenney
2008-02-01 6:37 ` [PATCH] add if_addrlabel.h to sanitized headers Stephen Hemminger
2008-02-05 11:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128.162104.132600552.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mitch@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).