From: David Miller <davem@davemloft.net>
To: paul.moore@hp.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
selinux@tycho.nsa.gov, stable@kernel.org, bunk@kernel.org,
jmorris@namei.org
Subject: Re: [PATCH] SELinux: Fix double free in selinux_netlbl_sock_setsid()
Date: Mon, 28 Jan 2008 19:51:24 -0800 (PST) [thread overview]
Message-ID: <20080128.195124.188485009.davem@davemloft.net> (raw)
In-Reply-To: <20080129022026.7930.18782.stgit@flek.lan>
From: Paul Moore <paul.moore@hp.com>
Date: Mon, 28 Jan 2008 21:20:26 -0500
> As pointed out by Adrian Bunk, commit 45c950e0f839fded922ebc0bfd59b1081cc71b70
> caused a double-free when security_netlbl_sid_to_secattr() fails. This patch
> fixes this by removing the netlbl_secattr_destroy() call from that function
> since we are already releasing the secattr memory in
> selinux_netlbl_sock_setsid().
>
> Signed-off-by: Paul Moore <paul.moore@hp.com>
Applied, and I'll queue this up for -stable too.
Please, when mentioning specific commits please also provide
the changelog headline along with the SHA1 hash.
The reason is that when this fix is moved over to another
tree where the SHA1 of the causing change is different people
studying your fix won't be able to find it without more stable
contextual information.
Thanks.
next prev parent reply other threads:[~2008-01-29 3:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 2:20 [PATCH] SELinux: Fix double free in selinux_netlbl_sock_setsid() Paul Moore
2008-01-29 3:51 ` David Miller [this message]
2008-01-29 17:13 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128.195124.188485009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@kernel.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=selinux@tycho.nsa.gov \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).